Skip to content

fix(phpstan): guard against a null user, not against false #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 3 commits into from
Aug 30, 2026
Merged

fix(phpstan): guard against a null user, not against false #828

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5bcc60
fix(phpstan): guard against a null user, not against false
rubenvdlinde Aug 30, 2026
8423502
Merge remote-tracking branch 'origin/development' into fix/phpstan-nu…
rubenvdlinde Aug 30, 2026
e719da0
style: Prettier the sidebar change here too
rubenvdlinde Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@
<!-- The manifest page's own sidebar (pages[].sidebarComponent). Passed in
as a slot prop because filling this slot suppresses CnAppRoot's
fallback, which is what hid the flow sidebar. -->
<component
:is="pageSidebarComponent"
v-if="pageSidebarComponent" />
<component :is="pageSidebarComponent" v-if="pageSidebarComponent" />
</template>
<!-- Suppress the default read-only CnTenantBadge — OrganisationSwitcher
below renders a combined active-organisation label + switcher
Expand Down Expand Up @@ -252,7 +250,7 @@
*
* @param {string} key Translation key.
* @return {string} Translated string (or the key on miss).
* @spec exclude i18n wrapper around @nextcloud/l10n translate

Check warning on line 253 in src/App.vue

View workflow job for this annotation

GitHub Actions / quality / Vue Quality (eslint) 

Unexpected inline JSDoc tag. Did you mean to use {@nextcloud}, \@nextcloud, or `@nextcloud`?
*/
translateForApp(key) {
return ncT('stackiq', key)
Expand Down
Loading