fix(nav): drop the hand-rolled Admin settings link - #1468
Merged
rubenvdlinde merged 2 commits intoSep 3, 2026
Conversation
ADR-110 Decision 2 and ADR-114 Decision 2: CnAppNav auto-prepends an Admin settings link to /settings/admin/<appId> for instance admins (ADR-079), and no app declares its own. shillinq declared `GeneralSettings` pointing at the same place, so the settings foldout carried two copies of one link. The app's copy had no isAdmin gating, which the shell's does, so it rendered for users who cannot open the page it points at. No capability is lost: the shell already draws the link. The fragment held nothing else, so it goes with the entry, and the id leaves menu-layout.json#settingsSection with it. tests/e2e/chart-of-accounts.spec.ts asserted this exact entry. It now asserts DeadlineCalendarSettings, the first id the settingsSection list carries. Deliberately an id this app OWNS: asserting on a shell-drawn entry would smoke the library rather than this manifest, and would keep passing over an app whose settings foldout went empty. That spec has now been repointed twice, and its comment records both moves. Also moves Features & roadmap from order 91 to 100: ADR-114 Decision 1 fixes the footer orders fleet-wide and reserves 95 for Reports.
src/manifest.d.shell.json is generated output that IS committed, and src/main.js builds the router table and the sidebar from the committed copy. Dropping the GeneralSettings fragment left the shell one menu id and one fragment stale. The drift is invisible locally because prebuild/predev/prewatch/pretest:unit all regenerate the file before anything reads it. Only the committed copy was stale, and only validate-manifest-shell looks at it.
Contributor
Quality Report — ConductionNL/shillinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-manifest-shell | ❌ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-manifest-budget | ✅ | ||||
| check-markers | ✅ | ||||
| check-registers | ✅ | ||||
| check-seeds | ✅ | ||||
| check-fragment-required | ✅ | ||||
| check-nav-reachability | ✅ | ||||
| check-job-registration | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-03 09:54 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
deleted the
fix/app-chrome-drop-the-hand-rolled-admin-link
branch
September 3, 2026 10:33
Contributor
Quality Report — ConductionNL/shillinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-manifest-shell | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-manifest-budget | ✅ | ||||
| check-markers | ✅ | ||||
| check-registers | ✅ | ||||
| check-seeds | ✅ | ||||
| check-fragment-required | ✅ | ||||
| check-nav-reachability | ✅ | ||||
| check-job-registration | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 10:35 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-110 Decision 2 and ADR-114 Decision 2:
CnAppNavauto-prepends an Admin settings link to/settings/admin/<appId>for instance admins (ADR-079), and no app declares its own.shillinq declared
GeneralSettingspointing at the same place, so the settings foldout carried two copies of one link. The app's copy had noisAdmingating, which the shell's does, so it rendered for users who cannot open the page it points at.No capability is lost. The shell already draws the link.
What
The fragment held nothing else, so it goes with the entry, and the id leaves
menu-layout.json#settingsSectionwith it. Features & roadmap moves from order 91 to 100 (ADR-114 Decision 1 reserves 95 for Reports).The e2e this would have broken
tests/e2e/chart-of-accounts.spec.tsasserted this exact entry bydata-testid. It now assertsDeadlineCalendarSettings, the first id thesettingsSectionlist carries.Deliberately an id this app owns: asserting on a shell-drawn entry would smoke the library rather than this manifest, and would keep passing over an app whose settings foldout went empty. That spec has now been repointed twice, and its comment records both moves.
Part of the ADR-114 app-chrome rollout (ConductionNL/hydra#643, gate ConductionNL/.github#668).
🤖 Generated with Claude Code