fix(manifest): drop the two bulk-action keys nothing reads - #1466
Merged
rubenvdlinde merged 1 commit intoSep 3, 2026
Conversation
gate-53 (effective-manifest-crossref) has failed on development since the nextcloud-vue 2.31.1 bump: /pages/432/config/bulkActions/0 — must NOT have additional properties BudgetToProgrammeLinker's "Link to Programme" bulk action declared `requiresSelection` and `dialog`. The manifest schema's `action` definition is additionalProperties:false and allows neither — and this is not a stale vendored schema, which was my first guess: nextcloud-vue 2.31.1's own copy rejects them identically. Nothing reads either key. No match for `requiresSelection` anywhere in @conduction/nextcloud-vue, none in this app's src beyond a prose docblock in BbvLinkerFilterBar.vue, and nothing reads `action.dialog`. The declared dialog — target programme select, effective date, submit and cancel labels — rendered nowhere. The action also carries no `type`, which the supported shape needs.⚠️ This DELETES declared intent. REQ-BBL-001 wanted a linking dialog on that bulk action and it has never worked. The manifest way to build it is `type: "open-modal"`, which merges the selection into the modal's props as `selectedIds` / `count`; that needs a modal component this app does not have. Removing the dead declaration makes the gap visible instead of leaving a promise the manifest cannot keep. The violation is OLDER than the commit that surfaced it: 70ba77f changed only package.json and the lockfile. The bump moved the gate onto a path that validates this page. Verified: the fragment is byte-identical apart from the two removed keys (parsed and compared, not eyeballed), and the full gate runner now exits 0 with gate-53 PASS.
Contributor
Quality Report — ConductionNL/shillinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-manifest-shell | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-manifest-budget | ✅ | ||||
| check-markers | ✅ | ||||
| check-registers | ✅ | ||||
| check-seeds | ✅ | ||||
| check-fragment-required | ✅ | ||||
| check-nav-reachability | ✅ | ||||
| check-job-registration | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 05:35 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gate-53 failure diagnosed in #1465.
BudgetToProgrammeLinker's "Link to Programme" bulk action declaredrequiresSelectionanddialog. The manifest schema'sactiondefinition isadditionalProperties: falseand allows neither:Not a stale vendored schema, which was my first hypothesis given the failure appeared on the nc-vue 2.31.1 bump while
.githublast synced its copy at 2.28.0. nc-vue 2.31.1's ownsrc/schemas/app-manifest-v2.schema.jsonrejects both keys identically.Nothing reads either key. No match for
requiresSelectionanywhere in@conduction/nextcloud-vue, none in this app'ssrc/beyond a prose docblock inBbvLinkerFilterBar.vue, and nothing readsaction.dialog. The declared dialog — target programme select, effective date, submit and cancel labels — rendered nowhere.This deletes declared intent, deliberately
REQ-BBL-001 wanted a linking dialog on that bulk action, and it has never worked. The supported shape is
type: "open-modal", which merges the selection into the modal's props asselectedIds/count— but that needs a modal component this app does not have, so building it is feature work rather than a fix.Removing the dead declaration makes the gap visible instead of leaving a promise the manifest cannot keep. If the dialog is still wanted, it should come back as a real modal.
Why a dependency bump surfaced it
70ba77f changed only
package.jsonand the lockfile. The violation is older than the commit that exposed it — the bump moved the gate onto a code path that validates this page.Verification
run-hydra-gates.shnow exits 0, with[gate-53] effective-manifest-crossref: PASS(13 WARN findings remain, all non-blocking and all pre-existing).Worth fixing separately
I could only see this violation because I ran the gate on a machine where
/tmpsurvives. In CI it is written to/tmp/hydra-gates.<rand>/and discarded, and neitherquality-report.mdnor the 154-byteresult-hydra-gatesartifact carries it — so the failure reads as "1 structural violation" with no way to learn which. Uploading that log alongside the existing artifact would turn this class of failure from an afternoon into a minute. Noted on #1465.