Skip to content

fix(clean-env): point the vendored skill at a script that exists - #1277

Merged
rubenvdlinde merged 4 commits into
developmentfrom
fix/clean-env-skill-points-at-a-real-script
Aug 27, 2026
Merged

fix(clean-env): point the vendored skill at a script that exists#1277
rubenvdlinde merged 4 commits into
developmentfrom
fix/clean-env-skill-points-at-a-real-script

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

This repo carries a copy of hydra's clean-env skill, and the copy told you to run bash .claude/scripts/clean-env.sh — a file that does not exist here, in hydra, or in any other checkout. Its app list was five names long against a fleet of twenty-one, and three of those five are app directories or retired apps rather than app ids, so following it by hand enables nothing.

Synced from hydra's canonical version (ConductionNL/hydra fix/clean-env-skill-points-at-a-real-script). It now drives .github/dev-up.sh, and its verification section names what to actually check: an app enables successfully with no vendor/autoload.php and then fatals on every request, and enables successfully with a pre-rename JS bundle and then renders a blank page. Both were true of live apps in the workspace on 2026-08-27, and "confirm apps are listed and enabled" sees neither.

Docs only — no code paths touched.

🤖 Generated with Claude Code

This repo carries a copy of hydra's clean-env skill, and the copy told you
to run `bash .claude/scripts/clean-env.sh` -- a file that does not exist
here, in hydra, or in any other checkout. Its app list was five names long
against a fleet of twenty-one, and three of those five (softwarecatalog,
docudesk-era names, mydash) are app directories or retired apps rather than
app ids, so following it by hand enables nothing.

Synced from hydra's canonical version. It now drives `.github/dev-up.sh`,
and its verification section names what to actually check: an app enables
successfully with no vendor/autoload.php and then fatals on every request,
and enables successfully with a pre-rename JS bundle and then renders a
blank page. Both were true of live apps in this workspace on 2026-08-27,
and "confirm apps are listed and enabled" sees neither.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/shillinq @ e757266

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-manifest-shell
format
check-l10n-js
check-schema-l10n
check-manifest-budget
check-markers
check-registers
check-seeds
check-fragment-required
check-nav-reachability
check-job-registration
test-l10n
composer ✅ 106/106
npm ✅ 551/551
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-27 10:28 UTC

Download the full PDF report from the workflow artifacts.

… gate-98 reads

gate-98 shipped yesterday and fails this repo on RetireSubsidieSchema. The
mechanism it reports is real -- the step's <step> entry is commented out, so
Nextcloud will never run it -- but the conclusion is wrong: it is commented
out on purpose. The reasoning was already written above it in prose (issue
#503): the step irreversibly deletes the Subsidie rows FoldIntoOrder folded,
so it must lag that fold by at least one release to leave a folded instance a
rollback window. Doing what the gate asked -- registering it -- would have
enabled a destructive step the team had deliberately withheld.

The prose stays. This adds the same decision in the machine-readable form the
gate now understands (.github#588), so the hold is recorded once and read by
both a person and the gate:

    <!-- hydra-gate-98 held: OCA\Shillinq\Repair\RetireSubsidieSchema — ... -->

The marker names this one class and carries the reason and the condition for
lifting it; it does not suppress anything else. RetireSubsidieSchema remains
unregistered and does not run.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/shillinq @ 5aca293

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-manifest-shell
format
check-l10n-js
check-schema-l10n
check-manifest-budget
check-markers
check-registers
check-seeds
check-fragment-required
check-nav-reachability
check-job-registration
test-l10n
composer ✅ 106/106
npm ✅ 551/551
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-27 11:52 UTC

Download the full PDF report from the workflow artifacts.

…skill-points-at-a-real-script

# Conflicts:
#	appinfo/info.xml
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/shillinq @ 3f6b494

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-manifest-shell
format
check-l10n-js
check-schema-l10n
check-manifest-budget
check-markers
check-registers
check-seeds
check-fragment-required
check-nav-reachability
check-job-registration
test-l10n
composer ✅ 106/106
npm ✅ 551/551
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-27 13:27 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 381982a into development Aug 27, 2026
99 of 137 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/shillinq @ b170094

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-manifest-shell
format
check-l10n-js
check-schema-l10n
check-manifest-budget
check-markers
check-registers
check-seeds
check-fragment-required
check-nav-reachability
check-job-registration
test-l10n
composer ✅ 106/106
npm ✅ 551/551
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-27 16:13 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

The one pending check, run locally with the canonical runner

88 CI checks are green here; only quality / Hydra Gates was still queued. Ran
it locally from ConductionNL/.github (the same source CI delegates to):

hydra-gates EXIT=0
COVERAGE: 68 of 78 declared gates reported a result (10 not applicable; 68 of 68 applicable gates ran)

The count matters as much as the exit code — a gate run that measures nothing
also exits 0. My first attempt reported 67 of 68 and two FAILs, both
environmental: ajv was not resolvable, and gate-60 skipped because
vue-material-design-icons was not installed. The gates refuse to run
fail-open, which is exactly right — "a weaker check reported as a pass is not
a pass."
Re-ran with NODE_PATH set and node_modules linked; gate-60 then
reported PASS and coverage reached 68 of 68.

Non-blocking advisories, unchanged by this PR: gate-18 (4 imperative-dispatch
sites) and gate-19 (290 scenarios missing @e2e, tracked in .github#477).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant