fix(e2e): the seed must refuse a truncated listing, not call it missing - #454
Merged
rubenvdlinde merged 1 commit intoSep 5, 2026
Merged
Conversation
The seed verified its required schemas against a paged listing and treated
absence-from-the-page as absence-from-the-instance. On a shared instance
holding 1,997 schemas a `_limit=1000` request returns the first page, and a
slug that fell off it reads exactly like a slug the import never created.
That failure mode is worse than a wrong answer: the message names the import as
the culprit, so the obvious next move is to debug an import that worked
perfectly. It cost a full seed-and-suite cycle on stackiq before I thought to
count the rows.
Two changes:
- Raise the page to 10,000 schemas and 2,000 registers.
- Compare `len(items)` against the response `total` and REFUSE when they
differ, rather than judging a population from a page.
The second matters more. A limit that is generous today is not generous
forever, and the next person to grow this instance should get "the listing is
truncated, raise the limit" instead of a fabricated missing slug.
Found by sweeping every ci-seed.sh in the fleet after hitting it twice:
opencatalogi (#1426) and stackiq. Four more were paging at 1000 against 1997,
and shillinq had headroom today but no guard.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 5, 2026 20:48
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 105/105 | |||
| npm | ✅ | ✅ 867/867 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 21:00 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The seed's schema verification now refuses a truncated listing instead of reporting the rows it never fetched as missing.
The bug
It verified required schemas against a paged listing and treated absence from the page as absence from the instance. On a shared instance holding 1,997 schemas, a
_limit=1000request returns the first page — and a slug that fell off it reads exactly like a slug the import never created:Both existed. Both were in the app's own register schema list.
That failure mode is worse than a wrong answer. The message names the import as the culprit, so the obvious next move is to go and debug an import that worked perfectly. It cost a full seed-and-suite cycle on stackiq before I thought to count the rows.
The fix
len(items)against the response'stotaland refuse when they differ, rather than judging a population from a page.The second part matters more than the first. A limit that is generous today is not generous forever, and the next person to grow this instance should get "the listing is truncated, raise the limit" rather than a fabricated missing slug.
Found by sweeping the fleet
After hitting this twice — opencatalogi (#1426) and stackiq — I checked every
ci-seed.sh:Four were actively broken against a loaded instance. shillinq had headroom but no guard, which is the same bug waiting for the instance to grow.
Verification
The shape was verified per app rather than assumed — portaliq's block lower-cases its slugs and needed its own patch. Every seed passes
bash -n, and stackiq's now reportsschemas present (1293 of 1293)and exits 0 against the loaded rig.