fix(e2e): the seed asks for the schema slug this app now declares - #578
Conversation
#575 renamed `timeEntry` to `plannedTimeEntry` — three apps declared a `timeEntry` and a schema slug is global per organisation. The seed's required-schema list still asked for the old name. That is the ninth hiding place a slug rename has, and the one that costs the most: the seed exits 1 before Playwright starts, so the whole suite is reported as NOT RUN rather than as failing. On development: ##[error]Planninq schemas missing after import: [timeEntry] ##[error]The e2e suite cannot seed a project, columns, tasks or labels ##[error]Seed command failed with exit 1 ...while the line above it listed `plannedTimeEntry` among the 28 schemas that had in fact imported. Verified against `lib/Settings/planninq_register.json` on development: every one of the six required slugs is declared. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Quality Report — ConductionNL/planninq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 536/536 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 14:09 UTC
Download the full PDF report from the workflow artifacts.
|
Merging with Measured on a clean
Worth a look by whoever owns #575, because covering them is not just adding keys: This PR is the seed fix: it asked for |
planninq's E2E leg does not fail. It never runs.
Read those two lines together: the schema imported fine, under the name it now has. #575 renamed
timeEntrytoplannedTimeEntry— three apps declared atimeEntry, and a schema slug is global per organisation — and the seed's required-schema list still asked for the old one.That rename was careful. It shipped
RenameTimeEntrySchemaSlugin both<post-migration>and<install>, and the commit message explains why the import's not-found branch would otherwise create a second schema and orphan every existing entry. It just missed this list, which is the hiding place that costs the most: the seed exits before Playwright starts, so every spec is reported as not run rather than as failing, and the leg looks like one broken seed instead of a suite that never executed.Verified
bash -non the script, and every one of the six required slugs checked againstlib/Settings/planninq_register.jsonondevelopment— all declared. The suite itself runs on thedevelopmentpush, since the E2E leg isskippingon pull requests.🤖 Generated with Claude Code