fix: two gates that were red on development - #1810
Merged
Merged
Conversation
…utch translation The two strings shipped as Dutch in the schema itself, so the catalogue had no key for them and the ratchet went red on development: 1912 uncovered against a baseline of 1910. Every other schema string in the app is English source translated through l10n, and the checker's own message says an untranslated string renders in English inside an otherwise translated form. The rendered Dutch is unchanged; it now comes from the catalogue rather than from the schema.
The demo-data step carried display: cards. Neither the hydra-vendored manifest schema nor the library's own accepts it, so gate-22 and gate-53 failed on development, and CnSetupWizard branches on step.type and never looks at step.display, so removing it changes nothing on screen. The app's own check:manifest passed it because that validator runs the laxer v1 path. If a choice step should be able to ask for cards, that is a schema and a renderer in nextcloud-vue, not a key an app can assert on its own.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 5, 2026 12:57
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 13:19 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two failures that had nothing to do with each other, both already on
development, both found by running the full check set after the marketing programme landed.The schema-l10n ratchet was red at 1912 uncovered against a baseline of 1910. The billing time-entry
titleanddescriptionshipped as Dutch in the schema itself, so the catalogue had no key for them. Every other schema string in the app is English source translated through l10n, and the checker's own message says an untranslated string renders in English inside an otherwise translated form. The rendered Dutch is unchanged; it now comes from the catalogue rather than from the schema.gate-22 and gate-53 failed on
src/manifest.json. The demo-data setup step carrieddisplay: "cards". Neither the hydra-vendored manifest schema nor the library's own accepts the key, andCnSetupWizardbranches onstep.typeand never looks atstep.display, so removing it changes nothing on screen. The app's ownnpm run check:manifestpassed it because that validator runs the laxer v1 path, which is exactly how it reacheddevelopment.If a choice step should be able to ask for cards, that is a schema and a renderer in
nextcloud-vue, not a key an app can assert on its own.Verification, by exit code
composer check:strict0 ·npm run format0 ·lint0 ·test:unit0 ·check:manifest0 ·check:spec-links0 ·check:schema-l10n0 (back at baseline 1910) ·check:l10n-js0 · hydra gates withHYDRA_GATE_BASE_REF=origin/development, full scope: 0, 80 of 80 applicable gates ran, up from two failures before this branch.🤖 Generated with Claude Code