Skip to content

fix: two gates that were red on development - #1810

Merged
rubenvdlinde merged 2 commits into
developmentfrom
fix/time-entry-schema-strings-english
Sep 5, 2026
Merged

fix: two gates that were red on development#1810
rubenvdlinde merged 2 commits into
developmentfrom
fix/time-entry-schema-strings-english

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Two failures that had nothing to do with each other, both already on development, both found by running the full check set after the marketing programme landed.

The schema-l10n ratchet was red at 1912 uncovered against a baseline of 1910. The billing time-entry title and description shipped as Dutch in the schema itself, so the catalogue had no key for them. Every other schema string in the app is English source translated through l10n, and the checker's own message says an untranslated string renders in English inside an otherwise translated form. The rendered Dutch is unchanged; it now comes from the catalogue rather than from the schema.

gate-22 and gate-53 failed on src/manifest.json. The demo-data setup step carried display: "cards". Neither the hydra-vendored manifest schema nor the library's own accepts the key, and CnSetupWizard branches on step.type and never looks at step.display, so removing it changes nothing on screen. The app's own npm run check:manifest passed it because that validator runs the laxer v1 path, which is exactly how it reached development.

If a choice step should be able to ask for cards, that is a schema and a renderer in nextcloud-vue, not a key an app can assert on its own.

Verification, by exit code

composer check:strict 0 · npm run format 0 · lint 0 · test:unit 0 · check:manifest 0 · check:spec-links 0 · check:schema-l10n 0 (back at baseline 1910) · check:l10n-js 0 · hydra gates with HYDRA_GATE_BASE_REF=origin/development, full scope: 0, 80 of 80 applicable gates ran, up from two failures before this branch.

🤖 Generated with Claude Code

…utch translation

The two strings shipped as Dutch in the schema itself, so the catalogue
had no key for them and the ratchet went red on development: 1912
uncovered against a baseline of 1910. Every other schema string in the app
is English source translated through l10n, and the checker's own message
says an untranslated string renders in English inside an otherwise
translated form. The rendered Dutch is unchanged; it now comes from the
catalogue rather than from the schema.
The demo-data step carried display: cards. Neither the hydra-vendored
manifest schema nor the library's own accepts it, so gate-22 and gate-53
failed on development, and CnSetupWizard branches on step.type and never
looks at step.display, so removing it changes nothing on screen. The app's
own check:manifest passed it because that validator runs the laxer v1
path.

If a choice step should be able to ask for cards, that is a schema and a
renderer in nextcloud-vue, not a key an app can assert on its own.
@rubenvdlinde
rubenvdlinde merged commit 43cbfed into development Sep 5, 2026
35 checks passed
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/pipelinq @ 05f52ff

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue-demi
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 106/106
npm ✅ 637/637
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates

Quality workflow — 2026-09-05 13:19 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant