fix(marketing): register mailTransport so the deliverability panel can read it - #1803
Merged
Merged
Conversation
…n read it The panel asked the object store for mailTransport rows and the store never issued a request: src/config/objectTypes.js is what fetchCollection resolves a type against, and mailTransport was the one schema in the app that a component reads this way without being listed there. Every tenant saw "No mail transports configured yet" beside three seeded transports, including the instance mail server every install gets for free. The wizard test deep-linked with a '#/blasts/new' hash though the app is path-routed, so it asserted against the dashboard.
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 12:03 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The deliverability panel asked the object store for
mailTransportrows and the store never issued a request.src/config/objectTypes.jsis whatfetchCollectionresolves a type against, andmailTransportwas the one schema in the app that a component reads this way without being listed there.Every tenant saw "No mail transports configured yet" next to three seeded transports, including the instance mail server every install gets for free. The objects were correct the whole time; nothing ever asked for them.
The wizard test deep-linked with a
#/blasts/newhash though the app is path-routed, so it asserted against the dashboard rather than the wizard.How it was found, and what else was checked
Playwright against the merged tree. I then swept every
fetchCollection('…')call insrc/against the registered slugs:mailTransportis the only one missing, so this is a single gap rather than a pattern.Verification, by exit code
composer check:strict0 ·npm run format0 ·lint0 ·test:unit0 ·check:manifest0 ·check:spec-links0 ·check:schema-l10n0 ·check:l10n-js0 · hydra gates withHYDRA_GATE_BASE_REF=origin/development, full scope: 0, 77 of 77 applicable gates ran.Playwright: marketing-transports 2/2, both previously failing. Confirmed in a browser before and after: the panel now lists the instance mail server with its SPF, DKIM and DMARC state.
🤖 Generated with Claude Code