feat(dossiq): declare ticket to dossiq as a case type - #1732
Merged
Conversation
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 2, 2026 06:58
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 07:06 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares pipelinq's
ticketto dossiq as a case type. A ticket is a case: dossiq owns case management, and pipelinq contributes the kind of work it handles rather than running a parallel system that merely resembles one.Pairs with ConductionNL/dossiq#1646, which adds the registry that discovers this.
The class is deliberately plain
Dossiq finds it by convention FQCN (
OCA\{App}\Dossiq\CaseTypeContributionProvider) and duck-types it viamethod_exists(), neverinstanceof— the same mechanism portaliq uses forPortalContributionProvider(ADR-046).So: no dossiq imports, no
implements, no info.xml dependency, no constructor dependencies. Without dossiq installed the class is inert and pipelinq behaves exactly as before, which is what{ "id": "dossiq", "required": false }in the manifest promises.An interface would read better and would make pipelinq hard-depend on dossiq. That is the coupling the pattern exists to avoid.
One case type, not three
The three ticket kinds stay one case type with a
ticketTypediscriminator, mirroring the storage:unify-ticket-supertypefolded request, complaint and interaction into a singleticketschema keyed by that field. Declaring three case types would re-split, on dossiq's side, exactly what that change joined.Verified
5/5 tests, and they guard the contract rather than an interface no compiler enforces:
Worth recording from the mutation run: renaming
getCaseTypestogetCasetypesdoes not fail these, because PHP method names are case-insensitive andmethod_existsstill matches. A genuine rename fails 3 tests. So casing drift there is harmless; a real rename makes the provider silently invisible, with nothing in any log naming pipelinq.phpcs clean. Committed through the GitHub API because another session holds 75 files of in-flight e2e work in the local checkout.