chore(deps): nextcloud-vue 2.36.0 - #3392
Merged
Merged
Conversation
Picks up two cascade fixes that only a real Nextcloud page could show, both of which reach users through THIS app's bundle: integration leaves render from openregister's integration-global entry, so a consuming app bumping the library does not move them. - Nextcloud sets margin-bottom: 3px on every plain button, at a specificity that beat the library's scoped rule, so tab strips sat 4px above their bar's rule and the open tab never met its panel. - A dynamic component root stopped Vue applying scope ids inside CnNotesCard, so Nextcloud's own textarea width won. Verified after rebuilding: the tab join measures 1px on a case detail page, against 5px before. One known gap remains and is NOT fixed by this bump: the integration-global entry resolves CnDetailCard's CSS but not the component itself, so a tabbed notes leaf renders <cndetailcard> as an unresolved element and loses its scoped styling. Tracked in #3387. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 20:56 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up two cascade fixes that only a real Nextcloud page could show, and that reach users specifically through this app's bundle: integration leaves render from openregister's
integration-globalentry, so a consuming app bumping the library does not move them.margin-bottom: 3pxon every plain button, with a selector scoring (0,2,1) against the library's scoped (0,2,0). Tab strips sat 4px above their bar's rule and the open tab never met its panel.CnNotesCard, so Nextcloud's owntextarea { width: 130px }won.Verified after rebuilding
The tab join measures 1px on a case detail page, against 5px before. Full width and the KPI tiles are unaffected.
One known gap this does NOT fix
The
integrationGlobalentry resolvesCnDetailCard's CSS but not the component: a tabbed notes leaf renders<cndetailcard>as an unresolved custom element and loses its scoped styling. The same page has a correctly resolved.cn-detail-cardelsewhere, so it is specific to that self-contained bundle, which is deliberately excluded from chunk splitting.Tracked in #3387. A global width floor landed in the library (ConductionNL/nextcloud-vue#984) so the composer is at least usable meanwhile, but the resolution gap itself belongs here.
🤖 Generated with Claude Code