chore(deps): @conduction/nextcloud-vue 3.0.0-vue3.4 - #2318
Merged
Conversation
Picks up the ADR-079 admin-settings link-out: the gear foldout's 'Admin settings' entry becomes an admin-gated LINK to /settings/admin/<app> instead of a modal, and ADR-079 Step 2's organisation credential broker home on CnAdminSettingsShell. Verified the feature is genuinely in the published tarball rather than trusting a green Release run: vue3.2 ships 0 files containing showAdminSettingsLink and 9 containing the removed cnOpenAdminSettings; vue3.4 ships the new API. Live-verified end-to-end on openconnector (ConductionNL/integriq#1136): the foldout renders Settings > Personal settings + Admin settings -> /settings/admin/openconnector, which returns 401 for an anonymous caller. Lockfile updated with --package-lock-only; CI builds and runs this app's own e2e against it.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 713/713 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-03 22:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the ADR-079 admin-settings link-out and Step 2's credential-broker home.
What changes for users: the gear foldout's Admin settings entry becomes an admin-gated link to
/settings/admin/<app>instead of a modal — app configuration lives in Nextcloud's settings framework, which authorizes it server-side.Verified the feature is genuinely in the published tarball rather than trusting a green Release run:
vue3.2ships 0 files containingshowAdminSettingsLinkand 9 containing the removedcnOpenAdminSettings;vue3.4ships the new API.Live-verified end-to-end on openconnector (ConductionNL/integriq#1136):
Lockfile updated with
--package-lock-only; CI builds and runs this app's own e2e against it.Related: nextcloud-vue#593 (Step 1), nextcloud-vue#594 (Step 2), hydra ADR-079.