chore(specs): audit+remediate retrofit REQs — group 5 (service facades) - #1902
Merged
Merged
Conversation
Convert bw2-svc-flat-2 requirement headings from Form B (REQ-ID prefix + sentence) to ADR-037 Form A (concise title, MUST stays in body first line); sync tasks.md anchors. Clarify text-extraction's relationship to the sibling text-extraction-sources handler cap. Add Why + retrofit frontmatter to the two new bw2-svc-flat-3 capabilities (schema-property-exploration, file-risk-classification). bw2-svc-flat-1 already conformant.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 165/165 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 16:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deep-audit + remediation of 3 retrofit service-facade changes (14 REQs total) to /opsx-ff quality. Annotation-only spec deltas; no runtime code changes.
REQ-XXprefix + full-sentence MUST) to Form A (concise noun-phrase title; MUST retained in the body first line). Synced tasks.md + proposal.md anchors. Clarifiedtext-extraction's layering relative to the siblingtext-extraction-sourceshandler cap.## Whyscoping +retrofit: truefrontmatter to both new-cap spec files (extra-scrutiny per new-capability rubric).Audit findings
openspec validate --strict.text-extraction(this group) andtext-extraction-sources(bw-svc-mid2, not in this PR) are complementary layers, not duplicates — see recommendation in the linked audit thread. No unilateral merge performed.Test plan
openspec validate retrofit-2026-05-25-bw2-svc-flat-1 --strictopenspec validate retrofit-2026-05-25-bw2-svc-flat-2 --strictopenspec validate retrofit-2026-05-25-bw2-svc-flat-3 --strict