feat: add ObjectServiceMapperAdapter - #1334
Closed
bbrands02 wants to merge 1 commit into
Closed
Conversation
Exposes a mapper-like API over ObjectService so external apps (e.g. OpenConnector) can interact with OpenRegister objects through a familiar contract without depending on ObjectService internals. Register and schema context are injected once at construction time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bbrands02
force-pushed
the
refactor/object-service-mapper-adapter
branch
from
April 23, 2026 12:02
7630c06 to
1a74c78
Compare
bbrands02
changed the title
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ✅ 147/147 | |||
| npm | ✅ | ✅ 599/599 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ❌ |
Quality workflow — 2026-04-23 12:03 UTC
Download the full PDF report from the workflow artifacts.
2 tasks
Contributor
Author
|
Superseded by new PR from feat/object-service-mapper-adapter branch. |
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 147/147 | |||
| npm | ✅ | ✅ 599/599 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-23 12:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectServiceMapperAdapter— a mapper-like adapter overObjectServiceObjectServiceinternalsMotivation
OpenConnector needs a way to call into OpenRegister using a mapper-like API. This adapter lives in OpenRegister so any external app can use it — not just OpenConnector.
Changes
lib/Service/ObjectServiceMapperAdapter.phpfind,findByUuid,findAll,createFromArray,updateFromArray,update,delete,getSchema,getRegister,getValidateHandlerRelated
Coordinated with openconnector#722 which updates the type hint references in
EndpointService.Test plan
ObjectServiceMapperAdaptercan be instantiated via DI with register/schema contextEndpointServiceresolves the adapter correctly after both PRs are merged🤖 Generated with Claude Code