Skip to content

fix(e2e): assert the deep link as a path, not a hash #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Sep 1, 2026
Merged

fix(e2e): assert the deep link as a path, not a hash #1344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions tests/e2e/spec-coverage/gate19.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ async function openIndexRoute(page: Page, route: string): Promise<void> {
* @param page The Playwright page.
* @param route The in-app route (e.g. '/catalogi/123').
*/
async function gotoHash(page: Page, route: string): Promise<void> {
async function gotoRoute(page: Page, route: string): Promise<void> {
await page.goto(`${APP}${route}`, { waitUntil: 'domcontentloaded' })
await page.waitForTimeout(1500)
await dismissOverlays(page)
Expand Down Expand Up @@ -188,22 +188,26 @@ test.describe('spa-deep-link-routing', () => {
* THEN it returns a TemplateResponse for the index template with a permissive connect-src CSP
* AND the front-end router resolves the remaining path client-side.
*
* The router is hash-mode, so the client-resolvable deep link is the
* hash form. We open #/search cold and assert the Search page (not the
* Dashboard fallback) actually rendered.
* The router is HISTORY-mode, so the client-resolvable deep link is a
* plain path. We open /search cold and assert the Search page (not the
* Dashboard fallback) actually rendered — the Dashboard is exactly what
* appears when the router cannot resolve the path and the catch-all
* redirects to `/`, which is the regression this guards.
*/
test(// @e2e spa-deep-link-routing::open-a-deep-link-directly
'SPA-001 — direct hash deep-link to /search renders the Search page, not the Dashboard', async ({
'SPA-001 — direct deep-link to /search renders the Search page, not the Dashboard', async ({
page,
}) => {
await gotoHash(page, '/search')
await gotoRoute(page, '/search')
// The genuine Search surface must mount from the deep link.
await expect(
page.locator('[data-testid="cn-search-page"]').first(),
).toBeVisible({ timeout: 20000 })
// And the URL kept the deep-link route.
// And the URL kept the deep-link route. Matched as a suffix: Nextcloud
// serves the app as both `/apps/...` and `/index.php/apps/...`, and the
// router emits whichever base the page was loaded under.
expect(page.url()).toContain('/apps/opencatalogi')
expect(page.url()).toContain('#/search')
expect(page.url()).toMatch(/\/apps\/opencatalogi\/search$/)
})
})

Expand Down Expand Up @@ -587,7 +591,7 @@ test.describe('catalogs', () => {
}) => {
const cat = await resolveOrSeedCatalog(request)
await bootApp(page)
await gotoHash(page, `/catalogi/${cat.id}`)
await gotoRoute(page, `/catalogi/${cat.id}`)
await expect(
page.locator('[data-testid="cn-detail-page"]').first(),
).toBeVisible({ timeout: 15000 })
Expand All @@ -606,7 +610,7 @@ test.describe('catalogs', () => {
}) => {
const cat = await resolveOrSeedCatalog(request)
await bootApp(page)
await gotoHash(page, `/publications/${cat.slug}`)
await gotoRoute(page, `/publications/${cat.slug}`)
// The Publications page is a manifest type:index page — its genuine
// surface is cn-index-page (not the dashboard).
await expect(
Expand Down Expand Up @@ -1055,7 +1059,7 @@ test.describe('publications', () => {
const errors = trackPageErrors(page)
const cat = await resolveOrSeedCatalog(request)
await bootApp(page)
await gotoHash(page, `/publications/${cat.slug}`)
await gotoRoute(page, `/publications/${cat.slug}`)
await expect(
page.locator('[data-testid="cn-index-page"]').first(),
).toBeVisible({ timeout: 15000 })
Expand All @@ -1079,7 +1083,7 @@ test.describe('publications', () => {
const errors = trackPageErrors(page)
const cat = await resolveOrSeedCatalog(request)
await bootApp(page)
await gotoHash(page, `/publications/${cat.slug}`)
await gotoRoute(page, `/publications/${cat.slug}`)
await expect(
page.locator('[data-testid="cn-index-page"]').first(),
).toBeVisible({ timeout: 15000 })
Expand Down
Loading