This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: mount the app independently of translation loading - #16
Merged
Conversation
`@nextcloud/l10n`'s loadTranslations() fetches l10n/<locale>.json and the returned promise rejects on a 404 (and on dev installs that rewrite non-allowlisted paths to index.php it always 404s). Mounting Vue inside the loadTranslations callback meant the whole UI silently failed to render whenever the locale bundle was missing — the page showed only the bare Nextcloud chrome. - Mount the Vue app unconditionally; load translations fire-and-forget and swallow the rejection (matches decidesk's main.js pattern). - Ship l10n/en_US.json (copy of en.json) so installs that DO serve it pick up the English bundle; other locales fall back to the source strings. Verified in the dev container: /apps/openbuilt/ now renders the Dashboard view with the sidebar (Dashboard / Schemas / Documentation / Settings).
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 430/430 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/19 statements)
Quality workflow — 2026-05-12 07:53 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/apps/openbuilt/rendered only the bare Nextcloud chrome — no sidebar, no Dashboard. Root cause:main.jsmounted the Vue app inside theloadTranslations('openbuilt', cb)callback.@nextcloud/l10n'sloadTranslations()fetchesl10n/<locale>.jsonand rejects on a 404 — and on dev installs that rewrite non-allowlisted paths toindex.php, thel10n/*.jsonrequest always 404s. So the callback never fired and nothing mounted.Fix
decidesk/src/main.js).l10n/en_US.json(copy ofen.json) so installs that do serve it pick up the English bundle; other locales fall back to the source strings.Verification
In the dev container,
/apps/openbuilt/now renders the Dashboard view with the full sidebar (Dashboard / Schemas / Documentation / Settings) and the sample KPI cards. (One harmlessl10n/en_US.json404 remains in the console on installs that rewrite that path — same as decidesk.)Pre-existing PHPUnit / Newman CI reds (no OpenRegister in CI — issue #11) are unrelated.