This repository was archived by the owner on May 29, 2026. It is now read-only.
build: fix frontend build (axios pin + SCSS + nc-vue beta.31) - #15
Merged
Conversation
…ump nc-vue - Pin @nextcloud/axios to ~2.5.2 — 2.6.x ships an "exports" field that webpack 5 can't resolve (build fails with ERR_PACKAGE_PATH_NOT_EXPORTED). - Bump @conduction/nextcloud-vue to ^1.0.0-beta.31 (manifest renderer family + the published CnAppRoot/useAppManifest API). - Add sass + sass-loader devDeps and a .scss webpack rule so components can use <style lang="scss"> (schema-editor sub-editors do). - Regenerate package-lock.json. Production build now succeeds (npm run build → js/openbuilt-main.js).
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-12 05:46 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 430/430 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-12 05:52 UTC
Download the full PDF report from the workflow artifacts.
- The RBAC explainer comment in appinfo/info.xml contained "--force" and
"--groups" — a double-hyphen, which is illegal inside an XML comment.
Nextcloud could not parse appinfo ("appinfo file cannot be read") and the
whole app failed to load. Rewrote the comment to drop the literal flags.
- Bump appinfo + package.json version 0.1.0 → 0.2.0 to match the OpenRegister
config file (lib/Settings/openbuilt_register.json info.version) and to
re-trigger the register-import + seed repair steps on deployed instances
after the schema-editor / versioning / rbac / export chain.
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 430/430 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/19 statements)
Quality workflow — 2026-05-12 05:56 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three small build-config fixes so
npm run buildsucceeds again:@nextcloud/axiosto~2.5.2—2.6.xships anexportsfield that webpack 5 chokes on (ERR_PACKAGE_PATH_NOT_EXPORTED).@conduction/nextcloud-vueto^1.0.0-beta.31— the published manifest-renderer family (CnAppRoot/useAppManifest/validateManifest).sass+sass-loaderdevDeps and a.scsswebpack rule — schema-editor sub-editors use<style lang="scss">.Regenerated
package-lock.json.Verification
NODE_ENV=production npx webpack --config webpack.config.js→ compiles clean (only the pre-existing asset-size warnings),js/openbuilt-main.js(7 MiB) +js/openbuilt-settings.jsproduced.Notes
PHPUnit / Newman CI jobs are red on
developmenttoo (no OpenRegister installed in CI — tracked in #11); not in scope here.