This repository was archived by the owner on May 29, 2026. It is now read-only.
chore: sync canonical root configs + mechanical phpmd cleanup - #127
Merged
Conversation
Phase 2 fleet root-config consolidation. Adopts the canonical
phpcs.xml / phpmd.xml / psalm.xml / phpstan.neon /
phpstan-bootstrap.php from nextcloud-app-template; pulls in the
SpecTagSniff + NoLegacyServerAccessorsSniff custom sniffs; renames
"AppTemplate" -> "OpenBuilt" in the two human-readable XML headers
only. The canonical phpcs and phpstan now exclude
lib/Resources/template/* (the verbatim template snapshot that
OpenBuilt itself drove); psalm + phpmd still see it, captured in
the tracking issue.
Mechanical phpmd cleanup (13 violations):
- 11 ElseExpression refactored to two-if pattern across
ApplicationCreationService (5), OpenBuiltToolProvider (4),
ProductionVersionGuardListener (1), SlugValidator (1).
- 2 UnusedLocalVariable ($preset) dropped from
ApplicationCreationService.
phpstan-baseline.neon captures 2 surviving errors (unused
constant in MigrateToVersionedModel + legacy \OC accessor in
IconService) so CI stays green while debt is tracked.
Architectural phpmd debt + psalm UndefinedClass noise stay
unfixed per fleet directive (no per-app rule relaxation);
tracked in #126.
Quality gates after sync:
- phpcs: 0 errors, 150 warnings (spec/missing-import advisory)
- phpstan: 0 errors (2 baselined)
- psalm: 20 errors (OR autoload + template snapshot, #126)
- phpmd: 37 violations (all architectural, #126)
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 591/591 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/19 statements)
Quality workflow — 2026-05-21 20:37 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 fleet root-config consolidation for openbuilt. Adopts the canonical
phpcs.xml/phpmd.xml/psalm.xml/phpstan.neon/phpstan-bootstrap.phpfromnextcloud-app-template; pulls in theSpecTagSniff+NoLegacyServerAccessorsSniffcustom sniffs; renamesAppTemplate->OpenBuiltin the two human-readable XML headers only.The canonical
phpcsandphpstanexcludelib/Resources/template/*(the verbatim template snapshot that openbuilt itself drove).psalmandphpmdstill see that path — captured in the tracking issue rather than relaxed per-app.Mechanical phpmd cleanup (13 violations)
ElseExpressionrefactored to two-if pattern acrossApplicationCreationService(5),OpenBuiltToolProvider(4),ProductionVersionGuardListener(1),SlugValidator(1).UnusedLocalVariable($preset) dropped fromApplicationCreationService.Out of scope (tracked)
Architectural phpmd debt (37 violations: ExcessiveClassComplexity, CyclomaticComplexity, NPathComplexity, etc.) and psalm
UndefinedClassnoise (mostly OR autoload visibility + template snapshot) stay unfixed per fleet directive — no per-app rule relaxation.phpstan-baseline.neoncarries 2 errors (unused constant inMigrateToVersionedModel, legacy\OCaccessor inIconService) so CI stays green.Tracked in #126.
Quality gates after sync
phpcs: 0 errors, 150 warnings (spec/missing-import advisory).phpstan: 0 errors (2 baselined).psalm: 20 errors (OR autoload + template snapshot, see Lint debt cleanup post-canonical-sync (Phase 2 fleet rollout) #126).phpmd: 37 violations (all architectural, see Lint debt cleanup post-canonical-sync (Phase 2 fleet rollout) #126).