This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(manifest-v2): TemplateGallery→index, designers→detail, FeaturesRoadmap→roadmap - #123
Merged
Merged
Conversation
…oadmap→roadmap (refs #112) Combines the #110 follow-up flips (TemplateGallery as cards-index, Page/SchemaDesigner as detail-with-slots, Exports as index over export-job) with the fleet-wide FeaturesRoadmap conversion to type:"roadmap" shipped in nc-vue beta.61 (nextcloud-vue#265). Page-type breakdown shifts from: dashboard:1 index:2 detail:0 custom:8 = 11 pages (73% custom) to: dashboard:1 index:5 detail:3 custom:1 roadmap:1 = 11 pages (9% custom) Flips (5 → typed primitives): * Schemas → type:"index" on openbuilt/application * Templates → type:"index" on openbuilt/application-template (cards viewMode — matches the original TemplateGallery shape Ruben called out: same data shape as index, just a different visualisation) * SchemaDesignerList → type:"index" on openbuilt/application (per-app schemas under /builder/:slug/schemas) * SchemaDesigner → type:"detail" + slots.default → SchemaDesignerView (CnDetailPage shell + bespoke designer canvas in the body slot) * PageDesigner → type:"detail" + slots.default → PageDesignerView (same pattern; bespoke three-pane manifest editor as body) * Exports → type:"index" on openbuilt/export-job Flip (1 → roadmap): * FeaturesRoadmap → type:"roadmap" (nc-vue CnFeaturesAndRoadmapPage auto-resolves repo/features/disabled via manifest config → loadState(appId, ...) → fallback chain) Stays custom (1 entry, genuine reason): * BuilderHost (/builder/:slug/:pathMatch(.*)?) — meta-app-shell that mounts a nested CnAppRoot rendering a virtual app's own manifest. No standard typed page covers "app inside app" runtime hosting. Side effects: * Deletes src/views/FeaturesRoadmap.vue (was wrapper for the old type:"custom" surface). * Drops unused TemplateGalleryView + ExportJobsView + FeaturesRoadmap entries from src/customComponents.js + src/registry.js (their pages are now typed primitives). * Bumps @conduction/nextcloud-vue ^1.0.0-beta.40 → ^1.0.0-beta.61.
Contributor
Quality Report — ConductionNL/openbuilt @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-20 10:16 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the #110/#112 follow-up flips with the fleet-wide FeaturesRoadmap conversion.
Flips (6 customs → typed primitives, leaves 1 residual):
Schemas(custom)indexon openbuilt/applicationTemplates(custom)indexon openbuilt/application-templateSchemaDesignerList(custom)indexon openbuilt/applicationSchemaDesigner(custom)detail+ slots.default → SchemaDesignerViewPageDesigner(custom)detail+ slots.default → PageDesignerViewExports(custom)indexon openbuilt/export-jobFeaturesRoadmap(custom)roadmapBuilderHost(custom)Type breakdown:
dashboard:1 index:2 detail:0 custom:8→dashboard:1 index:5 detail:3 custom:1 roadmap:1(73% → 9% custom).Bumps @conduction/nextcloud-vue
^1.0.0-beta.40→^1.0.0-beta.61for the type:"roadmap" enum + default-body fallback + CnDataTable guard.