chore: untrack sbom.cdx.json — the template shipped the file its own .gitignore forbids - #168
Merged
Merged
Conversation
.gitignore has listed sbom.cdx.json since line 102, but the file was already tracked when the rule landed, and gitignore does not apply to tracked files. So the template shipped a committed SBOM that the same repo declares should never be committed, and every app scaffolded from it inherited the file. The SBOM is generated per run by the shared quality workflow, published as the sbom-<app> artifact and attached to stable releases. A committed copy is stale the moment a lockfile moves. This one dated from the template's own scaffold and had not been regenerated since. Refs ConductionNL/.github#572, ConductionNL/hydra#617
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 24, 2026 22:20
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 737/737 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-24 22:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignorehas listedsbom.cdx.jsonsince line 102 — but the file was already tracked when that rule landed, and gitignore does not apply to tracked files. So the template has been shipping a committed SBOM that the same repository declares should never be committed, and every app scaffolded from it inherited the file.That is why
scholiq,decideskandopenbuildeach carry one: all three were scaffolded in May 2026, none has regenerated it since, and their lockfiles have moved many times underneath.The SBOM is generated per run by the shared quality workflow, published as the
sbom-<app-name>artifact, and — as ofConductionNL/.github#572— attached to stable releases. A committed copy is stale the moment a lockfile moves while still looking authoritative.hermiqalready gitignores it, with the comment "SBOM is published as release asset (see SECURITY.md), not stored in repo".13,031 lines removed. No rule change needed — the rule was already correct, only the tracking was wrong.
Refs
ConductionNL/.github#572,ConductionNL/hydra#617.