fix(frontend): two API URLs still named the schemas by their PascalCase slug - #781
Merged
Merged
Conversation
…se slug
Development E2E caught this, which is what it is for:
admissions review board page renders without a fatal error
Error: unexpected fatal errors: [AdmissionsReviewBoard] loadData error
Error: Application fetch failed: 404
AdmissionsReviewBoard fetched objects/learniq/Application and
TakeAssessmentView fetched objects/learniq/Assessment. Both name the schema
in the URL with the register's PascalCase DICT KEY rather than the slug, and
the resolution had been case-insensitive enough to cover the difference
until the slugs became admission and exam.
Every earlier sweep for these URLs was anchored on a lowercase slug, so
neither was ever in scope. The audit is now case-insensitive.
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 637/637 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 08:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #777. Found by development E2E, which is exactly what it is for:
Two Vue views build the OpenRegister URL with the register's PascalCase dict key rather than the slug:
AdmissionsReviewBoard.vueobjects/learniq/Applicationobjects/learniq/admissionTakeAssessmentView.vueobjects/learniq/Assessmentobjects/learniq/examResolution had been case-insensitive enough to cover key-vs-slug until the slugs became
admissionandexam. Every earlier sweep was anchored on a lowercase slug, so neither URL was ever in scope; the residual audit is now case-insensitive and reports learniq clean.🤖 Generated with Claude Code