fix(e2e): the chrome tests assert the shell LaunchPad renders - #547
Merged
rubenvdlinde merged 1 commit intoSep 5, 2026
Merged
Conversation
LaunchPad does not render CnAppNav, and that is deliberate: it does not root on CnAppRoot/NcContent, and App.vue says so where it writes its own `.workspace-shell` — org navigation rail, slide-in sidebar, branded DashboardFooter, its own skip link. Five tests asserted `[data-testid="cn-nav"]` and `.cn-app-nav__footer-list` anyway, from "feat(chrome): give launchpad a Store" (2026-09-04) onward. The E2E leg has been red on every push since: a beforeEach waiting 30 s for a nav that cannot appear, reported as five broken features. The manifest got the Store entry; the shell never got the nav. The chrome IS declared — Documentation, Store, Reports and Features & roadmap, in the manifest's footer section — and its destinations do work. So the tests check that instead: the four entries in order, each with an icon, Documentation as an external href, and each of the other three opening the page this app hosts. Read from the manifest rather than restated, so a renamed entry fails rather than going stale. Reports, the dashboards report, Store and Flows are reached by route, which is how they are reachable here. A new first test asserts the absence of CnAppNav. It is the premise the others rest on, and it is the tripwire: if this app ever adopts CnAppRoot, that fails where the reason is written down instead of leaving four tests passing against chrome that moved. The settings-foldout test drops its personal-settings assertion, because that entry is a CnAppNav widget with no equivalent in this shell. What survives is the part about LaunchPad rather than about the component: the admin settings section and the Flows page open. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 527/527 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 13:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchPad does not render
CnAppNav, and that is deliberate. It does not root onCnAppRoot/NcContent;App.vuesays so where it writes its own.workspace-shell— org navigation rail, slide-in sidebar, brandedDashboardFooter, its own skip link.Five tests asserted
[data-testid="cn-nav"]and.cn-app-nav__footer-listanyway, from "feat(chrome): give launchpad a Store" (2026-09-04) onward. The E2E leg has been red on every push since — last greendevelopmentrun was 2026-09-03. The failure is abeforeEachwaiting 30 s for a nav that cannot appear, reported as five broken features. The manifest got the Store entry; the shell never got the nav.What the tests check now
The chrome is declared, and its destinations do work. So:
href, and each of the other three naming a page this app hosts. Read fromsrc/manifest.jsonrather than restated as literals, so a renamed or dropped entry fails instead of going quietly stale./store,/reportsand/features-roadmapand asserts the shell rendered and the router matched.The tripwire
A new first test asserts the absence of
CnAppNav. It is the premise the others rest on, and it is deliberate: if LaunchPad ever adoptsCnAppRoot, that test fails where the reason is written down, instead of leaving four tests passing against chrome that has moved.One assertion is dropped, not moved
The settings-foldout test loses its personal-settings assertion. That entry is a
CnAppNavwidget with no equivalent in.workspace-shell, so there is nothing here to assert about it — saying otherwise would be the same mistake in a new place. What survives is the part about LaunchPad rather than about the component: the admin settings section renders, and the Flows page opens.Verified
prettier,eslintandplaywright test --listare green; six tests collect. Every manifest assertion in the new test was dry-run against the realsrc/manifest.jsonand passes: four labels in order, all four icons present, Documentation anhttps://href, and Store / Reports / FeaturesRoadmap resolving to/store,/reportsand/features-roadmap.The browser half runs on the
developmentpush, since the E2E leg isskippingon pull requests.🤖 Generated with Claude Code