feat(nav): give launchpad the Documentation and roadmap chrome - #529
Merged
rubenvdlinde merged 3 commits intoSep 3, 2026
Merged
Conversation
ADR-114 Decision 1: seven items belong at the bottom-left of every Conduction app. CnAppNav draws Personal settings and Admin settings itself; the other five are the app's own. launchpad shipped one of those five. Adds Documentation (footer, order 90, the app's own docs site) and Features & roadmap (footer, order 100) with its type:"roadmap" page, which ADR-018 has required of every app since it was written. Both icons had to be registered in src/icons.js. An unregistered name renders NO glyph, not a fallback, so shipping the entries alone would have put two blank rows in the footer. gate-60 caught it.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 3, 2026 09:45
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 09:51 UTC
Download the full PDF report from the workflow artifacts.
added 2 commits
September 3, 2026 11:52
The nl catalogue had it and en did not, so the two disagreed about a string this app now ships.
tests/l10n/check-l10n-parity.js requires all 36 European locales to carry every English source key, in BOTH the .json catalogues and the .js ones. A new user-facing label is therefore 36 translations, not one. Measured against origin/development before and after: 0 missing keys on the base, so these are the strings this branch introduced and nothing else. launchpad has no scripts/build-l10n-js.js, so the .js catalogues are maintained by hand and each got the key in the file's own style.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 09:59 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 10:14 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-114 Decision 1: seven items belong at the bottom-left of every Conduction app.
CnAppNavdraws Personal settings and Admin settings itself; the other five are the app's own. launchpad shipped one of those five (Flows).What
footer, order 90, pointing at https://launchpad.conduction.nl.footer, order 100, with itstype: "roadmap"page. ADR-018 has required this of every app since it was written; ADR-114 Decision 5 repeals the clause in that ADR which forbade gates from enforcing it.The part that would have shipped broken
Both glyphs had to be registered in
src/icons.js. An unregistered icon name renders no glyph at all, not a fallback and not a console error, so the entries alone would have put two blank rows in the footer. gate-60 caught it.Dutch key added to
l10n/nl.jsonandnl.jsfor gate-102.Part of the ADR-114 app-chrome rollout (ConductionNL/hydra#643, gate ConductionNL/.github#668).
🤖 Generated with Claude Code