Skip to content

revert(deps): re-pin @nextcloud/vue — the dropdown teleports under the modal mask - #452

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/repin-ncvue-pending-portal-fix
Aug 30, 2026
Merged

revert(deps): re-pin @nextcloud/vue — the dropdown teleports under the modal mask#452
rubenvdlinde merged 1 commit into
developmentfrom
fix/repin-ncvue-pending-portal-fix

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

The stacking fix in #450 was built on the first trace and was not enough. E2E on 9.11 with it merged is still 127 passed / 11 failed — the same eleven.

The second trace names a bigger interceptor than the first one did:

70x  class="modal-mask"
24x  class="checkbox-content__text checkbox-radio-switch__text"
20x  class="dashboard-config__hint"
18x  class="visibility-rule-row__actions"
 8x  class="dashboard-config__field dashboard-config__public"

modal-mask is Nextcloud's own modal backdrop, and it dominates. A z-index inside the modal cannot lift the dropdown above the mask if the dropdown is no longer inside the modal. 9.10's NcSelect appears to render its menu outside the dialog (appended/teleported to body), which puts it beneath the backdrop in stacking order. That is a different defect from the one #450 addressed, and it needs the menu kept in place or lifted above the mask — not more per-component z-index.

The CSS from #450 is kept. Those three smaller interceptors are real, each rule is documented against the trace that named it, and they are inert while the dropdown renders inline on 9.9.0.

So the pin goes back while the portal behaviour is worked out. This is not a finding that 9.11 is unusable — it is a decision not to sit red on development while holding a position.

…e modal mask

The stacking fix in #450 was built on the trace and was not enough. E2E
on 9.11 with it merged is still 127 passed / 11 failed, the same eleven.

The second trace names a bigger interceptor than the first one did:

  70x  class="modal-mask"
  24x  class="checkbox-content__text checkbox-radio-switch__text"
  20x  class="dashboard-config__hint"
  18x  class="visibility-rule-row__actions"
   8x  class="dashboard-config__field dashboard-config__public"

 is Nextcloud's own modal backdrop, and it dominates. A
z-index inside the modal cannot lift the dropdown above the mask if the
dropdown is no longer INSIDE the modal: 9.10's NcSelect appears to render
its menu outside the dialog (appended/teleported), which puts it beneath
the backdrop in stacking order. That is a different defect from the one
#450 addressed, and it needs the menu kept in place or lifted above the
mask -- not more per-component z-index.

The CSS from #450 is KEPT. Those three smaller interceptors are real, the
rule is documented against its trace, and it is inert while the dropdown
renders inline on 9.9.0.

So the pin goes back while that is worked out, because leaving
development red to hold a position is not a trade worth making. This is
not a decision that 9.11 is unusable -- it is a decision not to sit red
while the portal behaviour is understood.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 7f52122

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
format
check-schema-l10n
composer ✅ 104/104
npm ✅ 526/526
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright 🚨 NO VERDICT — enabled but never ran
Hydra gates

Quality workflow — 2026-08-30 16:40 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 67b9431 into development Aug 30, 2026
43 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/repin-ncvue-pending-portal-fix branch August 30, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant