revert(deps): restore the @nextcloud/vue pin — the experiment answered - #446
Merged
Conversation
The experiment in #443 has its answer, and it is the one that keeps the pin: E2E on 9.11 failed with the SAME ELEVEN tests and the SAME signatures as before. 127 passed, 11 failed 7x conditional-visibility-editor waiting for '.vs__dropdown-option' 4x dashboard-sharing waiting for '.sharee-option' That is deterministic, not load. Two independent CI runs on 9.11 produce an identical failure set, and 9.9.0 produces none, so the NcSelect rework is the cause. My isolated reproduction said otherwise -- those same specs passed on a 9.11 build against a seeded launchpad-demo -- and I have not yet found what differs between that environment and CI. That gap is real and worth closing before the specs are adapted, because adapting them against an environment that does not reproduce the failure fixes nothing. So development goes back to green on the pin while that work happens, rather than sitting red. The adaptation is still the plan; this is not a retreat from it. The one adaptation already understood and shipped separately is stackiq's (#841): 9.10 turned .vs__search from the <input> into a wrapper div around it, measured on a live build. launchpad's two failure modes are different and not yet explained.
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 526/526 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-30 15:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experiment in #443 has its answer, and it is the one that keeps the pin.
E2E on 9.11 failed with the same eleven tests and the same signatures as before:
That is deterministic, not load. Two independent CI runs on 9.11 produce an identical failure set, and 9.9.0 produces none. The NcSelect rework is the cause, and my earlier doubt was wrong.
An open gap I am not papering over
My isolated reproduction said the opposite — those same specs passed on a 9.11 build against a seeded
launchpad-demoinstance. I have not found what differs between that environment and CI. I checked the obvious candidate (that I copiedjs/but notcss/) and it does not explain it: the bundle has no separate stylesheet, so the styles are JS-injected and the overlay did carry them.That gap matters, because adapting the specs against an environment that does not reproduce the failure fixes nothing — it just produces a test that passes for the wrong reason.
So
developmentgoes back to green on the pin while that work happens, rather than sitting red. The adaptation is still the plan; this is not a retreat from it.What is already understood
The one adaptation that is pinned down shipped separately as stackiq#841: 9.10 turned
.vs__searchfrom the<input>into a wrapperdivaround it —— measured on a live 9.11 build. launchpad's two failure modes (
.vs__dropdown-optionnever stabilising,.sharee-optionnever appearing) are different and not yet explained.