fix(tests): declare the classes the connection report tests use - #719
Merged
rubenvdlinde merged 1 commit intoSep 16, 2026
Merged
Conversation
keepiq's phpunit.xml sets beStrictAboutCoverageMetadata and failOnRisky, and CI collects coverage, so a test that runs a class it neither @Covers nor @uses is risky and fails the cell. Twelve tests added in #706 ran ConnectionReporter, ConnectionObservations, SiemAuditTrail, SiemSink and SiemQueueItem without declaring them, which kept all six PHPUnit cells red on development with zero failing assertions (run 35012220984).
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-16 05:21 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Twelve tests added in #706 run
ConnectionReporter,ConnectionObservations,SiemAuditTrail,SiemSinkandSiemQueueItemwithout declaring them. This adds the matching@useslines to the three test classes.Why
phpunit.xmlsetsbeStrictAboutCoverageMetadata="true"andfailOnRisky="true", and CI collects coverage. A test that executes a class it neither@coversnor@usesis therefore risky, and a risky test fails the cell.All six PHPUnit cells stayed red on development after #717 with zero failing assertions:
OK, but there were issues! Tests: 1327, Assertions: 4320, Risky: 12.(run 35012220984).A local
composer check:strictcannot see this: it runs without coverage, so the strict coverage-metadata check never fires. That is why #717 looked complete.Verified
COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: ALL CHECKS PASSED.🤖 Generated with Claude Code