fix(waivers): drop the dead deployment excuse from nine emergency-access waivers - #704
Merged
rubenvdlinde merged 1 commit intoSep 14, 2026
Merged
Conversation
…ess waivers The waiver deferred a Playwright run because 'the worktree is not deployed and deploying to the shared dev instance is prohibited'. That reason never held: the E2E job provisions its own Nextcloud, seeded by tests/e2e/ci-seed.sh. The waiver now says what it actually covers (the server-side state machine) and that the routed, testid-hooked DOM flow is uncovered, not excluded. Ported from the unmerged wip/emergency-access-waiver-excuse (b1a66c1); its sibling commit already landed as #207.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-14 19:30 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Nine
@e2e excludewaivers in the emergency-access spec (eight inopenspec/specs/emergency-access/spec.md, one in theharden-vault-key-material-guardsdelta) deferred a Playwright run because "the worktree is not deployed and deploying to the shared dev instance is prohibited". That reason never held: the E2E Tests (Playwright) job provisions its own Nextcloud, seeded bytests/e2e/ci-seed.sh.Each waiver now says what it covers (the server-side state machine, tested by
EmergencyAccessServiceTest) and says plainly that the DOM flow insrc/views/EmergencyAccessView.vueis uncovered rather than excluded. No test is claimed that does not exist.Where it comes from
Consolidation of older unmerged work. Ported from
wip/emergency-access-waiver-excuse(commit b1a66c1, 2026-08-11). Its sibling commit on that branch already landed as #207. The branch itself was not merged; this is a fresh branch fromdevelopmentwith only the still-relevant change.Verified
diff-check.py --base origin/development: green, gates PASS, 0 new, 0 inherited.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: exit 0 (1280 tests, 9 skipped, all checks passed).npm run lint: exit 0.Spec text only, no code change. No inherited findings in the touched files.