fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite - #589
Closed
rubenvdlinde wants to merge 2 commits into
Closed
fix(e2e): the lint pass renamed Playwright fixtures, which killed the suite#589rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
… suite Playwright resolves a fixture BY NAME from the destructured parameter, so renaming an unused one to `_page` asks for a fixture that does not exist. The e2e leg dies before a single test runs and the report contains no test entries at all. Introduced by the pass that let the linter see tests/. The linter was right that the parameters were unused; underscore-prefixing is the fix for an ordinary unused argument and the wrong fix for a Playwright fixture, because the name is the lookup key. Same defect as buildiq#642, found by a fleet sweep.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 536/536 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 11:21 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Superseded: development already carries the canonical fix, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright resolves a fixture by name from the destructured parameter, so renaming an unused one to
_pageasks for a fixture that does not exist. The e2e leg dies before a single test runs, and the report contains no test entries at all:Introduced by the pass that let the linter see
tests/. The linter was right that the parameters were unused. Underscore-prefixing is the correct fix for an ordinary unused argument and the wrong fix for a Playwright fixture, because there the name is the lookup key.This is the same defect already fixed in buildiq (#642); a fleet sweep found it in four more apps.
The fix
Each parameter is genuinely unused, so it is removed rather than renamed back. The one exception is an
afterEachwhose own comment already documented the right shape.Verified
npx playwright test --listreports tests again, where it previously reported none.🤖 Generated with Claude Code