Skip to content

fix(e2e): click the button inside the Move action, not its li wrapper #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Aug 31, 2026
Merged

fix(e2e): click the button inside the Move action, not its li wrapper #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/e2e/workflows/folder-sharing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,13 @@ test.describe('Workflow: folders + sharing — folders/spec.md', () => {
await page
.getByRole('button', { name: /Secret actions/i })
.evaluate((el: HTMLElement) => el.click())
// `data-testid` falls through to NcActionButton's ROOT, which is the
// <li> wrapper, not the <button> carrying the click handler — so
// clicking the testid node itself is a silent no-op and the dialog
// never opens. Descend to the button.
await page
.getByTestId('secret-detail-move')
.locator('button')
.evaluate((el: HTMLElement) => el.click())
await expect(page.locator('.move-form')).toBeVisible({ timeout: 10_000 })
await page.locator('.move-form .vs__dropdown-toggle').click()
Expand Down
Loading