Skip to content

test(e2e): allow the walkthrough preference probe behind the lock screen #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Aug 29, 2026
Merged

test(e2e): allow the walkthrough preference probe behind the lock screen #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/e2e/workflows/vault-unlock.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,22 @@ test.describe('Workflow: vault unlock — encryption-suites/spec.md', () => {
// `:support-dialog="false"` would silence it by removing a feature
// rather than by judging the traffic.
/\/api\/preferences\/support-dialog-seen\b/,
// Same shell layer, same controller and the same judgement as the
// support-dialog entry above. CnAppRoot's
// resolveWalkthroughSeenVersion() runs whenever the manifest declares
// an enabled `walkthrough` block with a `completionConfigKey`
// (ADR-043), before any route resolves and therefore regardless of
// lock state. It reads one `pref_`-namespaced UI flag for the SESSION
// user — the last app version whose tour they have seen — and carries
// no vault material, so it is chrome, not a leak.
//
// The tour itself does NOT paint over the lock screen: the a11y
// snapshot captured when this endpoint first reached the wire shows
// the bare unlock form, with no walkthrough card in the tree. Only
// the preference probe is in scope here, which is what this entry
// covers — a tour that ever did open over the lock screen would be a
// rendering bug, and this entry does not hide it.
/\/api\/preferences\/walkthrough_completed_version\b/,
]

page.on('request', (req) => {
Expand Down
Loading