fix(ci): a push to development must reach a verdict here too - #474
Merged
Conversation
.github#597 set cancel-in-progress on the shared quality.yml, but a caller-level concurrency cancels the whole run before the called workflows setting can apply -- so that fix reached only the apps that declare no concurrency of their own. Measured 2026-08-28 over push runs on development since #597 merged: caller silent 0 of 11 cancelled caller says true 7 of 13 cancelled (54%) This repo is in the second group. pull_request keeps cancelling, where superseding really is correct.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 550/550 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 08:48 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes ConductionNL/.github#597, which only got half the fleet.
What #597 missed
#597 set
cancel-in-progress: ${{ github.event_name != 'push' }}on the sharedquality.yml. But a caller's ownconcurrencycancels the whole run before the called workflow's setting can apply — so the fix reached only the apps that declare no concurrency of their own.I reported #597 as fixing the cancellation. It fixed 8 of 21.
Measured, not assumed
Push runs on
developmentcreated after #597 merged (2026-08-27T19:45Z), completed runs only:cancel-in-progress: trueA clean natural experiment: same shared workflow, same traffic, the only difference is whether the caller overrides it. This repo is in the second group.
The change
One line, plus the comment explaining why it has to be said here and not only upstream:
pull_requestkeeps cancelling — there only the latest head commit is meaningful. The group expression is untouched, including itsSync to Betareasoning.Why it matters
A cancelled run is not a failure, but it is not a pass either — it is no verdict, and it renders as "nothing wrong here" in every summary that counts failures. Concrete casualties found today once runs started completing: learniq shipped an eslint error, dossiq shipped 15 invalid manifest actions rendering as empty clickable rows, launchpad shipped 8 untranslated strings, and openregister shipped a phpmd violation plus a broken flow-create E2E — none of them reported.
Verified: YAML parses on all 13 patched files; diff is the one line plus comment.