chore(deps): hydra-gates 1.10, so the E2E skip-discipline gate can run - #472
Merged
Conversation
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 550/550 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 06:23 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Aug 28, 2026
The skip-discipline gate now runs here (hydra-gates 1.10.0, #472) and reports one V3 finding — an exclusion with no reason recorded. The reason exists and is a good one; it sits in a block comment above the test, and `test.fixme(title, fn)` records no description in report.json. The body was a single line pointing AT that comment: // Intentionally empty — see block comment for the precise blocker. which tells a human where to look and a machine nothing. The reason moves onto the fixme itself, and the parenthetical leaves the title. Same test, still excluded, now attributable. Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and `playwright test --list` compiles all 8 tests with the exclusion intact. Part of ConductionNL/.github#609. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
conduction/hydra-gatesv1.10.0 containscheck_e2e_skips.py, which the shared quality workflow needs to run the E2E skip-discipline check. On v1.9.0 that script does not exist, so the step reportsand the job goes green having measured nothing. Today that is the state of 20 of 21 fleet apps — only launchpad, which was bumped in ConductionNL/launchpad#359, produces a verdict at all.
A skip is counted as a pass, and the Playwright report is the only place a runtime
test.skip(cond, reason)records its reason — the CI log prints counts without reasons. So until this lands, an app cannot tell a legitimate skip from a fixture that silently never ran. Context in ConductionNL/.github#609.Lock-only
composer.jsonalready allows this — the constraint is^1.8.2and 1.10.0 satisfies it. Onlycomposer.lockmoves.Blast radius, measured before opening this
v1.10.0 adds six gate scripts over v1.9.0:
So this is not a no-op bump, and it is deliberately opened as a PR rather than pushed: the gates run here and report before anything can redden
development.gate-99 manifest-l10n-coveragewas run locally against every fleet app first, because that is the gate that caught launchpad when it was bumped. 18 of 20 are clean; this app is one of them. The exception is zaakafhandelapp (59 manifest strings with nonl.jsonkey), which needs its l10n gap closed before it can take this bump.