fix(l10n): translate the two strings #448 added - #466
Merged
Conversation
#448 (frontend-improvements) added `Registered by` and `Requested` to the manifest. The manifest is data the renderer walks rather than source the l10n extractor scans, so neither reached the catalogue and both rendered English for a Dutch user. Registered by -> Geregistreerd door Requested -> Aangevraagd This is the drift the fleet check was added to catch, arriving the ordinary way: not a historical backlog, just the next PR that adds a manifest string. It took a couple of hours to appear, which is roughly the rate to expect. Worth noting `check:l10n-js` did NOT catch it and could not: nl.json and nl.js were in sync at 617 keys each, both simply missing the strings. That check guards source-versus-artifact drift, not manifest-versus-catalogue coverage. Different failure, different detector — humaniq's validate-l10n-parity.js is the one that asserts every manifest string has a key, and this app does not run it. Then `l10n:build`, because nl.json alone ships nothing. Verified: 0 manifest strings left without Dutch, keys DROPPED = 0 against the pre-change catalogues, check:l10n-js PASS, check-l10n-parity PASS.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 550/550 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-27 19:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#448 (frontend-improvements) added
Registered byandRequestedto the manifest. The manifest is data the renderer walks, not source the l10n extractor scans, so neither reached the catalogue and both rendered English for a Dutch user.Registered byRequestedThis is the ordinary case, not a backlog
The fleet-wide sweep cleared the historical debt. This is just the next PR that adds a manifest string — it appeared within a couple of hours, which is roughly the rate to expect.
check:l10n-jsdid not catch it, and could notnl.jsonandnl.jswere in sync at 617 keys each — both simply missing the strings.That check guards source-versus-artifact drift. This is manifest-versus-catalogue coverage. Different failure, different detector: humaniq's
validate-l10n-parity.jsasserts every manifest string has a key, and this app does not run it.Worth recording rather than assuming the check that exists covers everything.
Verification
check:l10n-jscheck-l10n-parity