Skip to content

fix(docs): publish the documentation from development, not a stale branch #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 3 commits into from
Aug 24, 2026
Merged

fix(docs): publish the documentation from development, not a stale branch #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2407217
fix(docs): publish the documentation from development, not a stale br…
rubenvdlinde Aug 24, 2026
a137ccb
fix(docs): name the worker that actually serves this site
rubenvdlinde Aug 24, 2026
05d3b8b
fix(docs): stop MDX parsing a placeholder as a JSX tag
rubenvdlinde Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Documentation

on:
push:
branches: [documentation]
branches: [development]
pull_request:
branches: [documentation]
branches: [development]

jobs:
deploy:
Expand All @@ -18,4 +18,12 @@ jobs:
# step with docs/static/CNAME.
cname: keepiq.conduction.nl

docs-hosts: doriath.conduction.nl,keepiq.conduction.nl
docs-hosts: doriath.conduction.nl,keepiq.conduction.nl

# Named explicitly, because the comment above already knows the answer
# and the workflow did not. The callee derives the worker from `cname`
# when not told — `keepiq-docs`, which does not exist. Deploying that
# creates a SECOND worker while both custom domains keep routing to
# `doriath-docs`: every deploy green, reaching nobody. Renaming the
# worker is a Cloudflare-side move, not something this file can perform.
worker-name: doriath-docs
2 changes: 1 addition & 1 deletion docs/application-secret-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ shows:
| Column | Notes |
|---|---|
| Status | Pending, Fulfilled, Declined, Expired |
| Expiry | "Expires <date>", "Expired <date>", or **"No expiry"** — a link that works forever |
| Expiry | `Expires <date>`, `Expired <date>`, or **"No expiry"** — a link that works forever |
| Token | Truncated. The full value goes to the clipboard only via **Copy fill link** |
| Requested fields | The field names asked for, e.g. `key, login` |

Expand Down
Loading