fix: add top and left spacing to empty-state messages across all object types - #729
Merged
Conversation
…ct types All "No … defined/found" empty-state texts were rendering flush against the container edge with no breathing room. - app.css: add global .emptyListHeader rule (margin-top/left 20px) covering all 8 list-view sidebars (webhooks, rules, jobs, mappings, consumers, endpoints, events, synchronizations) in one place. - SynchronizationDetails, JobDetails, MappingDetails, EventDetails: add scoped .tabPanel padding (15px top/bottom, 15px left) — these views used the class for empty-state divs but had no corresponding CSS. - ViewEndpoint, ViewMapping, ViewJob, ViewSource, ViewSynchronization: extend existing .tabPanel padding from vertical-only (15px 0) to include left spacing (15px 0 15px 15px). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove per-component scoped .tabPanel declarations and define the rule once globally. EndpointDetails retains a scoped override for text-align and color since it renders plain text rather than NcEmptyContent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SudoThijn
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All "No … defined/found" empty-state texts were rendering flush against the container edge with no breathing room. This PR adds consistent top and left spacing across every object type in the UI.
app.css: Added a global.emptyListHeaderrule (margin-top: 20px; margin-left: 20px;) covering all 8 list-view sidebars in one place: webhooks, rules, jobs, mappings, consumers, endpoints, events, and synchronizations.SynchronizationDetails,JobDetails,MappingDetails,EventDetails: Added scoped.tabPanel { padding: 15px 0 15px 15px; }— these detail views used the class for empty-state divs but had no corresponding CSS.ViewEndpoint,ViewMapping,ViewJob,ViewSource,ViewSynchronization: Extended existing.tabPanelpadding from vertical-only (15px 0) to include left spacing (15px 0 15px 15px).EndpointDetailsandJobLogIndexwere already styled correctly and left unchanged.Test plan
🤖 Generated with Claude Code