feat: use ObjectServiceMapperAdapter from OpenRegister - #723
Merged
Conversation
OpenRegister renamed OpenConnectorObjectMapperAdapter to ObjectServiceMapperAdapter to reflect that the adapter is not OpenConnector-specific and can be used by any external app. Updated the four type hint references in EndpointService accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7 tasks
ObjectServiceMapperAdapter::find() accepts both IDs and UUIDs, making findByUuid a redundant alias. Use find() directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rjzondervan
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EndpointServiceto referenceObjectServiceMapperAdapterfrom OpenRegisterChanges
lib/Service/EndpointService.php: Updated union type hints on 4 method signatures to use\OCA\OpenRegister\Service\ObjectServiceMapperAdapterRelated
Depends on openregister#1335 which adds the
ObjectServiceMapperAdapterclass.Test plan
EndpointServiceresolvesObjectServiceMapperAdaptercorrectly after the OpenRegister PR is merged🤖 Generated with Claude Code