Skip to content

Prevent fetched object double wrapping #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbrands02 merged 1 commit into from
Apr 15, 2026
Merged

Prevent fetched object double wrapping #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/Service/SynchronizationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,10 +628,12 @@ private function synchronizeExternToIntern(
$stageStartTime = microtime(true);
$result['objects']['found'] = count($objectList);

if ($sourceConfig['resultsPosition'] === '_object') {
$objectList = [$objectList];
$result['objects']['found'] = count($objectList);
}
if ($sourceConfig['resultsPosition'] === '_object') {
if (array_is_list($objectList) === false) {
$objectList = [$objectList];
}
$result['objects']['found'] = count($objectList);
}

$result['timing']['stages']['object_preparation'] = [
'duration_ms' => round((microtime(true) - $stageStartTime) * 1000, 2),
Expand Down Expand Up @@ -1942,9 +1944,9 @@ public function getAllObjectsFromApi(Synchronization $synchronization, ?bool $is
usesPagination: $usesPagination
);

if (array_is_list($objects) === false) {
$objects = [$objects];
}
if ($sourceConfig['resultsPosition'] !== '_object' && array_is_list($objects) === false) {
$objects = [$objects];
}

// Merge additional data into each object if $data is provided
if ($data !== null
Expand Down
Loading