Enable twig for endpoint - #713
Merged
Merged
Conversation
rjzondervan
approved these changes
Apr 14, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
Contributor
There was a problem hiding this comment.
PR Review
SSTI Risk — The endpoint string is passed directly to Twig rendering. If renderTemplateString() doesn't use a sandboxed environment, any user who can configure sourceConfig['endpoint'] could execute arbitrary code. Verify sandboxing before merging.
Rate-limit bypass — The reordering moves checkRateLimit() to after template rendering. This means rate-limited requests still do Twig processing before being rejected. Keep the rate-limit check at the top for fail-fast behavior.
WilcoLouwerse
approved these changes
Apr 14, 2026
4 tasks
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.