Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,26 @@ parameters:
- lib/Controller/EventsController.php
- lib/Controller/JobsController.php
- lib/Controller/LogsController.php
# MailIntakeService::intake() and ForwardService::forward() both
# return OCA\OpenRegister\Db\ObjectEntity, so getObject() on the
# result is an error type and the whole JSON payload reads as
# unresolvable. Same cause, same remedy, as the entries around it.
- lib/Controller/MailIntakeController.php
- lib/Controller/OutboundLogController.php
- lib/Controller/OpenFormulierenController.php
- lib/Controller/SourcesController.php
- lib/Controller/SynchronizationsController.php
- lib/Service/EndpointService.php
# The same OpenRegister-is-runtime-only effect, one layer further on.
# IntakeRoutingService::firstMatchingRule() fills $rules from
# ObjectEntity::getObject(), which resolves to an error type, so usort
# over that array is reported as unresolvable rather than the OR symbol
# itself. Scoped to the one file, like the JSONResponse block above.
-
message: '#Parameter \#?1? ?\$array of function usort contains unresolvable type#'
identifier: argument.unresolvableType
path: lib/Intake/IntakeRoutingService.php

# MappingService::executeMapping()'s `is_array($output) === false` guard.
# The comment directly above it already records the situation: "The
# is_array() guard is dead per static analysis but kept for safety
Expand Down
8 changes: 8 additions & 0 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@
<referencedClass name="OCA\OpenRegister\Event\ObjectUpdatingEvent"/>
<referencedClass name="OCA\OpenRegister\Event\ObjectUpdatedEvent"/>
<referencedClass name="OCA\OpenRegister\Event\ObjectDeletedEvent"/>
<!-- registry-subscription-connector: OpenRegister dispatches this
from RegistrySubscriptionNotifier and this app listens for it
lazily through addServiceListener, so the class is touched only
on an instance that has OpenRegister. Same reason, same
treatment, as the five sibling events above. The shape is
pinned by tests/stubs/OCA/OpenRegister/Event/RegistrySubscriptionRequestedEvent.php,
which the listener test runs against. -->
<referencedClass name="OCA\OpenRegister\Event\RegistrySubscriptionRequestedEvent"/>
<referencedClass name="OCA\OpenRegister\Service\ObjectService"/>
<!-- hitl-on-shared-tasks: the shared task service the HITL
mirror writes through, resolved at runtime like
Expand Down
Loading