fix(e2e): three reasons this leg is red — the demo-data choice, the Suggest-feature link, and a stale page-type copy

[rubenvdlinde]

Three failures on the E2E leg, unrelated to each other, all making development red on every push. It has not been green since 2026-09-03.

1. The demo-data test never chose a dataset

installing the demo data reports HOW MUCH landed, not just success posts the load action and then asserts the message names a non-zero object count. It never says which dataset to load.

That was fine while the step was a bare run-action. The step is a choice followed by a load step now, and the CI seed settles the optional steps by posting skip-demo-data, which records demo_dataset = none. The load then does exactly the right thing and imports nothing, so the test asserted against a decision it never made.

• api() gained a body parameter. It had none, so a test could not post a choice at all.
• Both install tests call pickShippedDataset(page) first, reading the id from GET /api/setup/status rather than writing 'demo' as a literal. The choice step declares optionsSource: datasets and carries no options of its own, so that response is the list an operator sees.

2. The Suggest-feature CTA is a link now

nextcloud-vue 2.36.4 deleted CnSuggestFeatureModal (team decision 2026-09-04: the forge is where the conversation happens). The header CTA became an anchor to the forge's feature-request issue form, and an <a href> has role link, so getByRole('button') matched nothing on a page that renders perfectly well.

The interactive test reads the target instead of clicking it. Clicking now leaves the app for a real issue form on a real forge, which in CI means navigating off the instance under test and out to the network.

3. The page-type list was a copy of an enum, and it drifted

manifest-pages.spec.ts kept twelve hand-written page types. reports has been in the manifest schema for a while, the manifest started using it, and this test called it unknown. Five types the copy was missing come back: reports, store, search, flows, flow-detail.

The set is read from the vendored schema now, and it throws if the enum is not there rather than falling back to a default — a test that cannot find the schema must say so, not quietly accept every type it is shown.

The Reports page also joins MANIFEST_PAGES, which is exactly what the sibling anti-staleness guard was reporting: a page nothing navigates to stops being smoke-tested with nothing going red. The table drives one test per entry, so /reports is driven now.

Verified

prettier, eslint and playwright test --list are green on all three changed files; the list collects 41 tests in manifest-pages.spec.ts, one per manifest page plus the four guards. The E2E leg is skipping on pull requests and runs on the development push, so the run after this merges is where it is proven.

🤖 Generated with Claude Code

[github-actions]

Quality Report — ConductionNL/integriq @ 7054c1f

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	⏭️
phpmd	⏭️
psalm	⏭️
phpstan	⏭️
phpmetrics	✅
eslint		✅
stylelint		⏭️
build		✅
format		✅
check-schema-l10n		✅
composer			⏭️	⏭️
npm			✅	⏭️
app:check-code	⏭️
info.xml	⏭️
REUSE	❌
PHPUnit					❌
Newman					❌
Playwright					❌
Hydra gates					❌

---

Quality workflow — 2026-09-05 12:39 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/integriq @ 44a6ab0

Check	PHP	Vue	Security	License	Tests
lint	⏭️
phpcs	⏭️
phpmd	⏭️
psalm	⏭️
phpstan	⏭️
phpmetrics	⏭️
eslint		⏭️
stylelint		⏭️
build		⏭️
composer			⏭️	⏭️
npm			⏭️	⏭️
app:check-code	⏭️
info.xml	⏭️
REUSE	❌
PHPUnit					❌
Newman					❌
Playwright					❌
Hydra gates					❌

---

Quality workflow — 2026-09-05 12:46 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/integriq @ 910d785

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
build		✅
check-specs		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 141/141
npm			✅	✅ 537/537
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-05 13:03 UTC

Download the full PDF report from the workflow artifacts.