feat(events): ADR-041 delivery seam for sibling-app outbound deliveries - #1810
Merged
Conversation
…over the CloudEvents pipeline
…nance ctor, fix the attempt-shape assertions
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 2, 2026 11:32
Contributor
Quality Report — ConductionNL/integriq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 141/141 | |||
| npm | ✅ | ✅ 537/537 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 11:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The receiving half of the fleet ruling case apps keep no delivery code: a typed-event seam (ADR-041) so a sibling app (dossiq first, PR pending on ConductionNL/dossiq) hands integriq an outbound delivery and gets an honest terminal answer back.
OCA\Integriq\Event\DeliveryRequestedEvent— provenance + payload + synchronous result slot (isHandled/getResultId/getMatchedSubscriptions; zero matches is reported honestly so the consumer fail-closes as unrouted).DeliveryRequestedListener— ingests the request into the existing CloudEvents pipeline asnl.conduction.delivery.requestedwith adata.deliveryprovenance block; subscriptions route it to webhook / flow / synchronization / notificaties actions and inherit retry, backoff, dead-letter, replay and HMAC signing unchanged.OCA\Integriq\Event\DeliveryConcludedEvent— dispatched from theevent_messageterminal transitions (deliveredon success,abandonedwhen the retry budget is spent), gated to provenance-carrying messages only. Dispatch failures are logged and swallowed; the message record stays the source of truth.EventServicegainsingestDeliveryRequest()and a nullableIEventDispatcherctor dep (same compatibility pattern asExecutionTraceService).EventServiceTestassertions read attempt keys thatappendAttempt()deliberately omits (PHP undefined-key warnings on every run); they now assert the documented key-absent contract.OpenSpec change:
openspec/changes/absorb-dossiq-deliveries/(proposal, design, tasks incl. staged phase-2 intake work with blockers,delivery-intakespec delta).Train order
This PR merges first. The dossiq PR (
dossiq-delivers-nothing) dispatches these events behindclass_exists()guards and fails closed, so no ordering breakage either way — but the seam only functions once this contract exists.Checks
--scope-to-diff: 0 FAIL, 33/33 applicable gates ran