feat(walkthrough): show where flows live, without making anyone build one - #613
Merged
Merged
Conversation
… one hermiq ships a flows surface (`FlowIndex`, routed at /flows and reachable from the settings menu) and its tour never mentioned it, so the automation was discoverable only to someone who already knew it was there. Found by widening gate 70's flows-page predicate: it matched only `type: "flows"`, which exactly one fleet app declares. hermiq ships its surface as an ordinary `type: "index"` page, so the gate reported NOT APPLICABLE and read as covered while covering nothing here. The step is `optional` with `allowManualNext`: showing where flows are edited must not become "author an automation before you may finish the tour". It targets `FlowIndex` — the ROUTE, which is what `data-cn-route` carries and what CnWalkthrough resolves. Targeting the menu id would look right in review and resolve to nothing at runtime, and an optional step whose target is absent is SKIPPED silently. hermiq's lock is already at 2.21.0, the release that put `data-cn-route` on CnAppNav's settings loop (#811), so the anchor exists. The three strings are added to l10n/en.json and nl.json by hand: hermiq's own `test:l10n` does not read src/manifest.json — it reports OK with all three missing — so gate-101 in CI is the only thing that would catch it. Verified: gate-70 0 findings, gate-96 rc=0, test:l10n OK, check:l10n-js rc=0.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 28, 2026 12:47
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 123/123 | |||
| npm | ✅ | ✅ 742/742 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 12:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(walkthrough): show where flows live, without making anyone build one
hermiq ships a flows surface (
FlowIndex, routed at /flows and reachablefrom the settings menu) and its tour never mentioned it, so the automation
was discoverable only to someone who already knew it was there.
Found by widening gate 70's flows-page predicate: it matched only
type: "flows", which exactly one fleet app declares. hermiq ships itssurface as an ordinary
type: "index"page, so the gate reported NOTAPPLICABLE and read as covered while covering nothing here.
The step is
optionalwithallowManualNext: showing where flows areedited must not become "author an automation before you may finish the
tour".
It targets
FlowIndex— the ROUTE, which is whatdata-cn-routecarriesand what CnWalkthrough resolves. Targeting the menu id would look right in
review and resolve to nothing at runtime, and an optional step whose target
is absent is SKIPPED silently. hermiq's lock is already at 2.21.0, the
release that put
data-cn-routeon CnAppNav's settings loop (#811), so theanchor exists.
The three strings are added to l10n/en.json and nl.json by hand: hermiq's
own
test:l10ndoes not read src/manifest.json — it reports OK with allthree missing — so gate-101 in CI is the only thing that would catch it.
Verified: gate-70 0 findings, gate-96 rc=0, test:l10n OK, check:l10n-js rc=0.