Skip to content

feat(walkthrough): show where flows live, without making anyone build one - #613

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/walkthrough-flows-stop
Aug 28, 2026
Merged

feat(walkthrough): show where flows live, without making anyone build one#613
rubenvdlinde merged 1 commit into
developmentfrom
chore/walkthrough-flows-stop

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

feat(walkthrough): show where flows live, without making anyone build one

hermiq ships a flows surface (FlowIndex, routed at /flows and reachable
from the settings menu) and its tour never mentioned it, so the automation
was discoverable only to someone who already knew it was there.

Found by widening gate 70's flows-page predicate: it matched only
type: "flows", which exactly one fleet app declares. hermiq ships its
surface as an ordinary type: "index" page, so the gate reported NOT
APPLICABLE and read as covered while covering nothing here.

The step is optional with allowManualNext: showing where flows are
edited must not become "author an automation before you may finish the
tour".

It targets FlowIndex — the ROUTE, which is what data-cn-route carries
and what CnWalkthrough resolves. Targeting the menu id would look right in
review and resolve to nothing at runtime, and an optional step whose target
is absent is SKIPPED silently. hermiq's lock is already at 2.21.0, the
release that put data-cn-route on CnAppNav's settings loop (#811), so the
anchor exists.

The three strings are added to l10n/en.json and nl.json by hand: hermiq's
own test:l10n does not read src/manifest.json — it reports OK with all
three missing — so gate-101 in CI is the only thing that would catch it.

Verified: gate-70 0 findings, gate-96 rc=0, test:l10n OK, check:l10n-js rc=0.

… one

hermiq ships a flows surface (`FlowIndex`, routed at /flows and reachable
from the settings menu) and its tour never mentioned it, so the automation
was discoverable only to someone who already knew it was there.

Found by widening gate 70's flows-page predicate: it matched only
`type: "flows"`, which exactly one fleet app declares. hermiq ships its
surface as an ordinary `type: "index"` page, so the gate reported NOT
APPLICABLE and read as covered while covering nothing here.

The step is `optional` with `allowManualNext`: showing where flows are
edited must not become "author an automation before you may finish the
tour".

It targets `FlowIndex` — the ROUTE, which is what `data-cn-route` carries
and what CnWalkthrough resolves. Targeting the menu id would look right in
review and resolve to nothing at runtime, and an optional step whose target
is absent is SKIPPED silently. hermiq's lock is already at 2.21.0, the
release that put `data-cn-route` on CnAppNav's settings loop (#811), so the
anchor exists.

The three strings are added to l10n/en.json and nl.json by hand: hermiq's
own `test:l10n` does not read src/manifest.json — it reports OK with all
three missing — so gate-101 in CI is the only thing that would catch it.

Verified: gate-70 0 findings, gate-96 rc=0, test:l10n OK, check:l10n-js rc=0.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/hermiq @ fa40d4a

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-specs
check-manifest
test-l10n
format
check-l10n-js
check-schema-l10n
composer ✅ 123/123
npm ✅ 742/742
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright 🚨 NO VERDICT — enabled but never ran
Hydra gates

Quality workflow — 2026-08-28 12:51 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 8629dcc into development Aug 28, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant