test: collect the unit tests filinq was never running, and fix the stub gap they hid

[rubenvdlinde]

What

phpunit.xml collects tests/unit. A second tests/Unit existed beside it, holding Controller/SetupControllerTest.php and Service/DemoDataServiceTest.php. On a case-sensitive filesystem those are two different directories, so 12 tests have never run in CI.

Moving them alone would have turned development red

That is the part worth reading. Six of the twelve error out the moment they are collected:

Trying to configure method "getAppPath" which cannot be configured because it
does not exist, has not been specified, is final, or is static

tests/stubs/NextcloudStubs.php declares IAppManager with isInstalled, isEnabledForUser, getAppVersion and getInstalledApps, and stops there. OCP's real interface also declares getAppPath, which DemoDataServiceTest mocks.

A stub that is shorter than the interface it stands in for does not fail where it is short. PHPUnit refuses to configure the method that is missing, and the test errors far from the omission, so it reads as a broken test rather than a short stub. The test was correct all along.

getAppPath is added to the stub with OCP's signature.

Result

All 12 pass. Collected tests go from 1755 to 1767, with no failures.

Tests: 1767, Assertions: 5163, Skipped: 3

phpcs --standard=phpcs.xml exits 0.

Scope

The two test files are moved and their namespaces brought onto the convention the collected directory already uses (OCA\Filinq\Tests\Unit\…; they were on a bare Unit\…). No assertion is changed.

Same defect elsewhere

larpinq carries it too, fixed in ConductionNL/larpinq#669. There the uncollected directory held one file and no stub gap. A sweep of the other 19 fleet apps found no third case: every other repo either configures both spellings or configures the one its tests actually live in.

[github-actions]

Quality Report — ConductionNL/filinq @ 9550118

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
test		✅
test-unit		✅
check-manifest		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 118/118
npm			✅	✅ 631/631
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					✅
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-01 21:27 UTC

Download the full PDF report from the workflow artifacts.