chore(psalm): drop six suppressions whose bugs are already gone - #976
Merged
Conversation
psalm-baseline.xml suppressed six InvalidArgument issues. None of them still exist. Emptying the baseline and re-running Psalm reports "No errors found", so every entry was outliving the code it described. Three named registerEventListener in lib/AppInfo/Application.php, and that method is not in the file any more. The other three named $statusCode in AnonymizationController and PdfController, and those paths now type-check on their own. A baseline that suppresses nothing real is not neutral: it is a standing invitation to add the next entry rather than fix the cause, and it hides whether the count is going up or down. The file is kept, empty, so the next genuine finding still has somewhere to be recorded deliberately. Verified locally with the repo own vendor/bin/psalm 5.26.1 against PHP 8.3: with the baseline emptied, 271 files analysed, no errors.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 31, 2026 15:59
Contributor
Quality Report — ConductionNL/filinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| test-unit | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 118/118 | |||
| npm | ✅ | ✅ 631/631 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-31 16:08 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All six entries in
psalm-baseline.xmlare stale. Emptying the baseline and re-running Psalm reports No errors found, so nothing in it still describes real code.registerEventListenerinlib/AppInfo/Application.php— that method is no longer in the file at all;$statusCodeinAnonymizationControllerandPdfController— those paths now type-check on their own.A baseline that suppresses nothing real is not harmless. It invites the next entry instead of the next fix, and it makes the count meaningless as a trend. The file is kept but emptied, so a genuine future finding still has a deliberate home.
Verified locally with this repo own
vendor/bin/psalm5.26.1 on PHP 8.3: 271 files analysed, no errors with the baseline empty.