fix(transitions): every status transition 500s on an empty guard details

[rubenvdlinde]

Making a status transition from the UI has been answering 500 since
73c0570e2. The dialog never closes and the case does not move. This is a
user-facing break, not only three red E2E tests.

From nextcloud.log on the failing run, six times:

POST /index.php/apps/dossiq/api/case/<id>/transition
[dossiq] StatusTransitionController: execute failed
Property 'evaluatedGuards.0.details' expects object but got empty ({}).
For non-required object properties, set this to null to clear the field.

Why

GuardRegistry::evaluateAll() copies each GuardResult verbatim into the
snapshot that CaseStatusStore persists as statusRecord.evaluatedGuards,
whose details is declared type: object. GuardResult::$details defaults to
an empty array, and a guard with nothing to report leaves it that way, so the
rejected shape is the common one, not an edge case.

It stayed invisible until the status checklist guard began being appended to
every transition. Before that, a transition declaring no guards produced no
snapshot entries at all, so there was nothing to reject. Afterwards every
transition carried at least entry 0. StatusTransitionController::execute()
catches \Throwable, so a validation failure surfaced as a 500 rather than as
a message anyone could read, which is why this reads as a hung dialog.

The fix

Empty details is written as null, which is what OpenRegister's own error
message asks for. Details a guard does populate are untouched: the
unknown-guard branch and every failing guard keep what they reported, or the
reason a transition was refused would stop being recorded. There is a control
test for that.

The third test states the invariant the schema actually cares about, that no
snapshot entry carries an empty details, so a new guard cannot reintroduce
this by defaulting the field again.

Verification

PHPCS on lib                                     clean
tests/Unit/Service/Transitions (125 tests)       OK, 255 assertions
the three new tests, with the fix reverted       2 of 3 fail

One trap worth recording

This app's vendor autoloader maps OCA\Dossiq\ to $baseDir/lib, where
$baseDir is whichever checkout composer installed in. A first run of these
tests silently exercised a sibling checkout's code and reported the fix as
ineffective. The numbers above come from a run that loads this branch's lib/,
confirmed by reflecting on the loaded class's file path before running.

[github-actions]

Quality Report — ConductionNL/dossiq @ 174244d

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		❌
composer			✅	✅ 106/106
npm			✅	✅ 541/541
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					❌
Newman					⏭️
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-08 13:51 UTC

Download the full PDF report from the workflow artifacts.

[github-actions]

Quality Report — ConductionNL/dossiq @ 2526537

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue3-compile		✅
test-l10n		✅
format		✅
check-schema-l10n		✅
check-l10n-js		✅
composer			✅	✅ 106/106
npm			✅	✅ 541/541
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					✅
Newman					⏭️
Playwright					⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates					✅

---

Quality workflow — 2026-09-08 14:21 UTC

Download the full PDF report from the workflow artifacts.