Skip to content

fix(manifest): the deep link names the task slug this app renamed - #1847

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/the-deeplink-names-the-renamed-task-slug
Sep 5, 2026
Merged

fix(manifest): the deep link names the task slug this app renamed#1847
rubenvdlinde merged 1 commit into
developmentfrom
fix/the-deeplink-names-the-renamed-task-slug

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

One missed key, three red jobs

#1845 namespaced task to caseTask and swept the manifest thoroughly — every "schema": "task" moved. But deepLinks addresses its target through schemaSlug, a different key name, so the sweep did not reach it.

The consequences reported separately, which is why this looked like three problems:

job what it saw
Frontend Tests (unit) searchableSchemas.spec.js asserts a deepLinks entry for every searchable schema; the register now declares caseTask as searchable and the manifest still offered task
Hydra gate-53 effective-manifest-crossref resolves deepLinks against the declared schemas, so a slug nothing declares is a cross-reference failure
Frontend Check (format) prettier, on the spec file the same commit had edited

The spec kept the old name too

Two more places, and the comment sitting between them already stated the rule it was breaking:

The KEY is the schema slug and moved with it; the URL is a published ROUTE and deliberately did not — a route resolves at request time, so breaking one fails silently.

That was written for the objectionProceeding rename and is just as true for this one. Both maps move; the /apps/dossiq/tasks/{uuid} template and the /tasks/:id route stay.

Verification

  • 366 unit tests pass across 36 files
  • gate-53 reports {"status":"passed","checked":1,"failed":0}, with the same 7 non-blocking WARNs CI already reported
  • prettier clean across the repo, eslint clean

🤖 Generated with Claude Code

Three of dossiq's four red jobs on development are one missed key. #1845
namespaced `task` to `caseTask` and swept the manifest thoroughly — every
`"schema": "task"` moved — but `deepLinks` addresses its target through
`schemaSlug`, a different key name, so the sweep did not reach it.

The consequences reported separately, which is why this looked like three
problems:

  Frontend Tests (unit)  searchableSchemas.spec.js asserts a deepLinks entry for
                         every searchable schema; the register now declares
                         `caseTask` as searchable and the manifest still offered
                         `task`.
  Hydra gate-53          effective-manifest-crossref resolves deepLinks against
                         the declared schemas, so a slug nothing declares is a
                         cross-reference failure.
  Frontend Check         prettier, on the spec file the same commit had edited.

The spec kept the old name in two more places, and the comment sitting between
them already stated the rule it was breaking: "the KEY is the schema slug and
moved with it; the URL is a published ROUTE and deliberately did not". That was
written for the `objectionProceeding` rename and is just as true for this one.
Both maps move; the `/apps/dossiq/tasks/{uuid}` template and the `/tasks/:id`
route stay, because a route resolves at request time and breaking one fails
silently.

Verified locally: 366 unit tests pass across 36 files, gate-53 reports
`{"status":"passed","checked":1,"failed":0}` with the same 7 non-blocking WARNs
CI already reported, prettier clean across the repo, eslint clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 27404bd

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue3-compile
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 106/106
npm ✅ 541/541
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman ⏭️
Playwright ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates

Quality workflow — 2026-09-05 20:52 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit f0edde0 into development Sep 5, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant