fix(manifest): the deep link names the task slug this app renamed - #1847
Merged
rubenvdlinde merged 1 commit intoSep 5, 2026
Merged
Conversation
Three of dossiq's four red jobs on development are one missed key. #1845 namespaced `task` to `caseTask` and swept the manifest thoroughly — every `"schema": "task"` moved — but `deepLinks` addresses its target through `schemaSlug`, a different key name, so the sweep did not reach it. The consequences reported separately, which is why this looked like three problems: Frontend Tests (unit) searchableSchemas.spec.js asserts a deepLinks entry for every searchable schema; the register now declares `caseTask` as searchable and the manifest still offered `task`. Hydra gate-53 effective-manifest-crossref resolves deepLinks against the declared schemas, so a slug nothing declares is a cross-reference failure. Frontend Check prettier, on the spec file the same commit had edited. The spec kept the old name in two more places, and the comment sitting between them already stated the rule it was breaking: "the KEY is the schema slug and moved with it; the URL is a published ROUTE and deliberately did not". That was written for the `objectionProceeding` rename and is just as true for this one. Both maps move; the `/apps/dossiq/tasks/{uuid}` template and the `/tasks/:id` route stay, because a route resolves at request time and breaking one fails silently. Verified locally: 366 unit tests pass across 36 files, gate-53 reports `{"status":"passed","checked":1,"failed":0}` with the same 7 non-blocking WARNs CI already reported, prettier clean across the repo, eslint clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 541/541 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-05 20:52 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One missed key, three red jobs
#1845 namespaced
tasktocaseTaskand swept the manifest thoroughly — every"schema": "task"moved. ButdeepLinksaddresses its target throughschemaSlug, a different key name, so the sweep did not reach it.The consequences reported separately, which is why this looked like three problems:
searchableSchemas.spec.jsasserts adeepLinksentry for every searchable schema; the register now declarescaseTaskas searchable and the manifest still offeredtaskeffective-manifest-crossrefresolvesdeepLinksagainst the declared schemas, so a slug nothing declares is a cross-reference failureThe spec kept the old name too
Two more places, and the comment sitting between them already stated the rule it was breaking:
That was written for the
objectionProceedingrename and is just as true for this one. Both maps move; the/apps/dossiq/tasks/{uuid}template and the/tasks/:idroute stay.Verification
{"status":"passed","checked":1,"failed":0}, with the same 7 non-blocking WARNs CI already reported🤖 Generated with Claude Code