Count queue rows once a row is on the page - #1802
Merged
Merged
Conversation
`the queue holds strictly fewer rows than the case index` failed against a queue that was completely correct. The spec counted rows as soon as `cn-page` became visible, and that happens while the table is still fetching — so it read 0 rows from a page about to render 9, and `4 < 0` is false. Measured live while diagnosing: /cases renders 9 rows, /queue renders 4. The filter was never in doubt; only the moment the count was taken. Both counts now wait for the first row to be visible before reading, via one helper so the two pages cannot drift apart in what they wait for. Suite now 4 of 4 green, and work-navigation 3 of 3 and navigation 4 of 4 against the same instance.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 541/541 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-04 09:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the queue holds strictly fewer rows than the case indexfailed against a queue that was completely correct.The spec counted rows as soon as
cn-pagebecame visible, and that happens while the table is still fetching — so it read 0 rows from a page about to render 9, and4 < 0is false.Measured live while diagnosing:
/casesrenders 9 rows,/queuerenders 4. The filter was never in doubt; only the moment the count was taken.Both counts now wait for the first row to be visible before reading, through one helper so the two pages cannot drift apart in what they wait for.
Verification
Against a throwaway instance carrying merged
development, seeded to be discriminating (9 cases: 3 assigned, 2 closed, queue 4):spec-coverage/queue.spec.tsspec-coverage/work-navigation.spec.tsnavigation.spec.tsTest-only change.