The queue note named the wrong reason the isnull filter was dead - #1800
Merged
Merged
Conversation
…as dead The Queue page's note said `assignee_isnull=true` fails because `SearchQueryHandler::cleanQuery` compares the value with `=== true`. That is a real defect in that method, and it is not why the filter was dead. `cleanQuery()` has no production callers at all. What normalises a suffixed parameter is `buildSearchQuery()`'s underscore-to-nested reconstruction, and `isnull` was missing from `MagicSearchHandler::COMPARISON_OPERATORS` — so the filter contributed no condition rather than an inverted one. Measured over HTTP: both `_isnull=true` and `_isnull=false` returned 0 rows, which is the tell. An inverted operator would have answered correctly for one of them. Fixed in openregister `isnull-filter-operator`. The `IS NULL` sentinel stays here because it also works on instances that do not yet carry that change. No behaviour change: the filter itself was, and remains, correct.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
September 4, 2026 07:15
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-04 09:00 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Queue page's note said
assignee_isnull=truefails becauseSearchQueryHandler::cleanQuerycompares the value with=== true.That is a real defect in that method, and it is not why the filter was dead.
cleanQuery()has no production callers at all. What normalises a suffixed parameter isbuildSearchQuery()'s underscore-to-nested reconstruction, andisnullwas missing fromMagicSearchHandler::COMPARISON_OPERATORS— so the filter contributed no condition rather than an inverted one.Measured over HTTP: both
_isnull=trueand_isnull=falsereturned 0 rows. That is the tell. An inverted operator would have answered correctly for one of them.Fixed in openregister
isnull-filter-operator. TheIS NULLsentinel stays here because it also works on instances that do not yet carry that change.No behaviour change
The filter itself was, and remains, correct. Verified on a live instance seeded to be discriminating: 9 cases, 3 assigned, 2 closed, queue = 4.
Documentation only.