chore(deps): nextcloud-vue 2.35.5 - #1789
Merged
Merged
Conversation
Two cascade fixes found by measuring the running app, both invisible to the e2e harness because it is a bare vite page with none of Nextcloud's own CSS: - 2.35.4: Nextcloud sets margin-bottom: 3px on every plain button, at a specificity that beat the component's scoped rule, so the tabs sat 4px above the bar's rule and the open tab never met its panel. - 2.35.5: a dynamic root stopped Vue applying the scope id inside CnNotesCard, so Nextcloud's own textarea width won and the compose box rendered 130px wide inside a 992px panel. Verified on the running instance after this bump: the open tab's computed margin-bottom is -1px and the last tab row sits 1px above the panel, against 3px and 5px before. The notes composer itself will not change until openregister is bumped: its bundle owns the integration registry, so the notes leaf renders from ITS copy of the library. Tracked in openregister#3387. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 20:03 UTC
Download the full PDF report from the workflow artifacts.
The seed conformance test reads a merged register to know which properties a schema declares, so it executes RegisterFragmentMerger without asserting anything about it. Under strict coverage PHPUnit marks that risky, and the run exits 1 while reporting zero failures: OK, but there were issues! Tests: 3036, Assertions: 20093, Warnings: 2, Skipped: 3, Risky: 1 It fires only when a coverage driver is loaded, which is why the suite is green locally and red on all six CI cells. @uses rather than @Covers: the merger is a dependency of the fixture, not the subject. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
September 3, 2026 20:05
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 20:24 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
pushed a commit
that referenced
this pull request
Sep 3, 2026
development moved again while this branch was being fixed, and the PR went back to CONFLICTING, which is why no quality workflow ran on the previous push: GitHub runs no pull_request workflows when it cannot compute a merge commit. Four checks still pass in that state (CodeQL, conflict markers), and on a dashboard that is indistinguishable from a full pass. One conflict, and it is the same fix twice. #1789 carried `test(seed): declare RegisterFragmentMerger as used`, the identical @uses tag added here one commit earlier. Took theirs: same tag, plus a docblock paragraph explaining why the test is risky only under a coverage driver. Verified by EXIT CODE this time, not by reading the summary, which is what missed three failures on the previous round: format 0, lint 0, stylelint 0, test:unit 0, phpcs 0, phpstan 0, psalm 0, hydra-gates 0, phpunit 0 excluding StubApiDriftTest. StubApiDriftTest is excluded from that local number on purpose. It compares tests/Stubs/ against the sibling ../openregister working tree, which another session is editing: it has now reported StoreDescriptor drift in both directions within an hour as that checkout changed branch. CI clones openregister fresh and passes it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up two cascade fixes, both found by measuring the running app and both invisible to the e2e harness, which is a bare vite page carrying none of Nextcloud's own CSS.
2.35.4 — Nextcloud's server stylesheet sets
margin-bottom: 3pxon every plain button, with a selector scoring (0,2,1) against the component's scoped (0,2,0). The tabs sat 4px above the bar's rule, so the open tab never met its panel and the folder-tab join was only ever visible outside the app.2.35.5 — A dynamic
<component :is>root stopped Vue applying the scope id insideCnNotesCard, so every scoped rule missed and Nextcloud's owntextarea { width: 130px }won: the compose box rendered 130px wide inside a 992px panel. That one was my own regression from earlier in the session.Verified on the running instance after this bump
margin-bottom3px-1pxOne thing this does not fix
The notes composer itself. OpenRegister's bundle owns the integration registry, so the
notesleaf renders from its copy of the library, which is still on 2.35.1. Rebuilding dossiq changes nothing there, which is what I measured rather than assumed.Tracked in ConductionNL/openregister#3387. I did not do that bump because openregister's checkout holds another session's uncommitted work in
src/navigation/MainMenu.vue.🤖 Generated with Claude Code