refactor(case-detail): drop the three duplicate KPI cards from the bottom row - #1701
Merged
rubenvdlinde merged 1 commit intoSep 3, 2026
Merged
Conversation
…ttom row `Open tasks`, `Documents` and `Sub-cases` were `stats-block` widgets sitting in the bottom layout row (gridY 19), each showing a count of something the page already lists in full a few centimetres away: the tab strip carries Files and Sub-cases panels, and the right column carries Tasks. Every one of the three counted rows the reader can already see and count, so the row cost a screenful of height and told them nothing new. `Hours booked` stays. It is the one stats-block whose number is NOT derivable from anything else on the page: it sums humaniq TimeEntry rows, which the case detail does not list. The widget definitions and their layout entries both go, 88 lines in total, and nothing else referenced them: the two surviving mentions are historical prose in a `_note` and in a test comment, both describing what the page used to carry.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 05:19 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open tasks,DocumentsandSub-caseswerestats-blockwidgets in the bottom layout row (gridY: 19), each showing a count of something the page already lists in full a few centimetres away: the tab strip carries the Files and Sub-cases panels, and the right column carries Tasks. Every one counted rows the reader can already see, so the row cost a screenful of height and told them nothing new.Hours bookedstays. It is the one stats-block whose number is not derivable from anything else on the page: it sums humaniqTimeEntryrows, which the case detail does not list.Scope
Both the widget definitions and their layout entries go, 88 lines, 0 lines added. Nothing else referenced them: the two surviving mentions are historical prose in a
_noteand in a test comment, both describing what the page used to carry.Verification
npm run check:manifest: Ajv PASS, 0 errors against schema 2.28.0case-kpis-open-taskscase-detail-kpis-and-tabs.spec.ts+deelzaak-support.spec.tsagainst that build: 10 passed, 2 skipped, 0 failed. The KPI spec asserts theCase typeandCompletedcards and the right column (Hours booked, Flow runs, Tasks), none of which this touches.