The cases visual baseline was a screenshot of the dashboard - #1685
Merged
Conversation
… none Two loose ends from the label fix that shipped in #1677. THE CASES BASELINE WAS A SCREENSHOT OF THE DASHBOARD, and now there is proof rather than an inference: `cases-visual-linux.png` and `dashboard-visual-linux.png` were byte-identical, same md5. `shootByNav` resolves its label behind `if (isVisible)`, so when dossiq#1646 renamed the entry the click silently never happened and the shot was taken wherever the app had landed — the Dashboard, under the name cases.png, for as long as that rename has been in. #1677 fixed the LABEL, which made the test correct and left the baseline wrong: the next visual run would have compared the real cases page against a dashboard image and failed, looking like a regression in the page rather than a stale artefact. Regenerated, and it now differs from the dashboard, which is the assertion that was never available before. The store baseline is new. gate-26 accepted the visual TEST added in #1677, but every other visual test carries a committed baseline and this one did not, so the first person to run the visual project would have hit a missing snapshot. Both shot against a dedicated instance. The `visual` project is deliberately excluded from CI — tests/e2e/playwright.config.ts is the config the workflow resolves, precisely so a CI Linux runner never tries to byte-match a dev-container PNG — so these are for local runs and carry no CI risk.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 2, 2026 18:21
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-02 19:08 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two loose ends from the label fix in #1677.
The cases baseline was the dashboard, and here is the proof
cases-visual-linux.pnganddashboard-visual-linux.pngwere byte-identical — same md5,32e5617a73a834cf6c1a6fb7c4abc24b. Not an inference from reading the code: the artefacts themselves were the same image.shootByNavresolves its label behindif (await link.isVisible()), so when #1646 renamed the entry the click silently never happened and the screenshot was taken wherever the app had landed. That is the Dashboard, filed ascases.png, for as long as that rename has been in.#1677 fixed the label. That made the test correct and left the baseline wrong — the next visual run would have diffed the real cases page against a dashboard image and failed, reading as a regression in the page rather than a stale artefact. Regenerated; it now differs from the dashboard, which is the assertion that was never actually available before.
The store baseline was missing
gate-26 accepted the visual test added in #1677, but every other visual test carries a committed baseline and this one did not. The first person to run the visual project would have hit a missing snapshot.
No CI risk
The
visualproject is deliberately excluded from CI:tests/e2e/playwright.config.tsis the config the shared workflow resolves, chosen precisely so a CI Linux runner never tries to byte-match a dev-container PNG. Both images were shot against a dedicated instance and are for local runs.🤖 Generated with Claude Code